From: Junio C Hamano <gitster@pobox.com>
To: "Zoë Blade" <zoe@bytenoise.co.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] userdiff: add support for Fountain documents
Date: Mon, 20 Jul 2015 14:17:57 -0700 [thread overview]
Message-ID: <xmqqegk2y1dm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: 1437309082-19060-1-git-send-email-zoe@bytenoise.co.uk
Zoë Blade <zoe@bytenoise.co.uk> writes:
> diff --git a/userdiff.c b/userdiff.c
> index 2ccbee5..5a600d6 100644
> --- a/userdiff.c
> +++ b/userdiff.c
> @@ -35,6 +35,8 @@ IPATTERN("fortran",
> * they would have been matched above as a variable anyway. */
> "|[-+]?[0-9.]+([AaIiDdEeFfLlTtXx][Ss]?[-+]?[0-9.]*)?(_[a-zA-Z0-9][a-zA-Z0-9_]*)?"
> "|//|\\*\\*|::|[/<>=]="),
> +PATTERNS("fountain", "^((\\.|(([Ii][Nn][Tt]|[Ee][Ss][Tt]|[Ee][Xx][Tt])?\\.?|[Ii]([Nn][Tt])?\\.?/[Ee]([Xx][Tt])?\\.?) ).+)$",
> + "[^ \t-]+"),
Wouldn't IPATTERN() be a better choice here?
> PATTERNS("html", "^[ \t]*(<[Hh][1-6][ \t].*>.*)$",
> "[^<>= \t]+"),
> PATTERNS("java",
next prev parent reply other threads:[~2015-07-20 21:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 12:31 [PATCH] userdiff: add support for Fountain documents Zoë Blade
2015-07-20 21:17 ` Junio C Hamano [this message]
2015-07-21 13:23 ` Zoë Blade
-- strict thread matches above, loose matches on Subject: below --
2015-07-21 13:22 Zoë Blade
2015-07-21 19:33 ` Junio C Hamano
2015-07-22 16:31 ` Zoë Blade
2015-07-29 11:19 ` Zoë Blade
2015-07-17 14:21 Zoë Blade
2015-07-17 17:12 ` Junio C Hamano
2015-07-17 22:43 ` Junio C Hamano
2015-07-19 12:30 ` Zoë Blade
2015-07-17 11:59 Zoë Blade
2015-07-17 13:03 ` Johannes Schindelin
2015-07-17 14:03 ` Zoë Blade
2015-07-17 16:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegk2y1dm.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=zoe@bytenoise.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).