From: Junio C Hamano <gitster@pobox.com>
To: Armin Kunaschik <megabreit@googlemail.com>
Cc: Jeff King <peff@peff.net>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t0008: 4 tests fail with ksh88
Date: Fri, 20 May 2016 08:16:43 -0700 [thread overview]
Message-ID: <xmqq37pchi90.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CALR6jEhviK9KZxR6R6xzkZ5EAO-RjWj3xYah_DOSDXhEjYsT-A@mail.gmail.com> (Armin Kunaschik's message of "Fri, 20 May 2016 16:31:30 +0200")
Armin Kunaschik <megabreit@googlemail.com> writes:
> From: Armin Kunaschik <megabreit@googlemail.com>
>
> \" in the test t0008 is not treated the same way in bash and in ksh.
Could you refrain from singling out "bash"? We don't write for
"bash" specifically (and the test I ran are with "dash" before I
push things out).
Ideally, if you can try ksh93 and if you find out that ksh93 works,
then the above can be made in line with your "Subject" to mark ksh88
as broken (as opposed to other POSIX shells)? That would help us by
reminding that running test fine with ksh93 is not a sufficient
check to make sure we didn't break ksh88 users.
> In ksh the \ disappears and generates false expect data to
> compare with.
> Using \\" works portable, the same way in bash and in ksh and
> is less ambigous.
All of the above would need s/ksh/&88/g; I'd think. I just tried
make SHELL_PATH=/bin/ksh93
cd t && /bin/ksh93 t0008-*.sh
and this patch is not necessary for ksh93.
> Acked-by: Jeff King <peff@peff.net>
I didn't see him acking this exact version, so if you didn't include
this line here, I would have missed it. Thanks.
> Signed-off-by: Armin Kunaschik <megabreit@googlemail.com>
> ---
> diff --git a/t/t0008-ignores.sh b/t/t0008-ignores.sh
> index 89544dd..b425f3a 100755
> --- a/t/t0008-ignores.sh
> +++ b/t/t0008-ignores.sh
> @@ -605,7 +605,7 @@ cat <<-EOF >expected-verbose
> a/b/.gitignore:8:!on* a/b/one
> a/b/.gitignore:8:!on* a/b/one one
> a/b/.gitignore:8:!on* a/b/one two
> - a/b/.gitignore:8:!on* "a/b/one\"three"
> + a/b/.gitignore:8:!on* "a/b/one\\"three"
> a/b/.gitignore:9:!two a/b/two
> a/.gitignore:1:two* a/b/twooo
> $global_excludes:2:!globaltwo globaltwo
> @@ -686,7 +686,7 @@ cat <<-EOF >expected-all
> a/b/.gitignore:8:!on* b/one
> a/b/.gitignore:8:!on* b/one one
> a/b/.gitignore:8:!on* b/one two
> - a/b/.gitignore:8:!on* "b/one\"three"
> + a/b/.gitignore:8:!on* "b/one\\"three"
> a/b/.gitignore:9:!two b/two
> :: b/not-ignored
> a/.gitignore:1:two* b/twooo
next prev parent reply other threads:[~2016-05-20 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 14:31 [PATCH] t0008: 4 tests fail with ksh88 Armin Kunaschik
2016-05-20 15:16 ` Junio C Hamano [this message]
2016-05-20 16:10 ` Junio C Hamano
2016-05-20 16:14 ` Armin Kunaschik
2016-05-20 21:01 ` Christian Couder
2016-05-20 16:11 ` Armin Kunaschik
2016-05-22 0:07 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37pchi90.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=megabreit@googlemail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).