From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Armin Kunaschik <megabreit@googlemail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t0008: 4 tests fail with ksh88
Date: Sat, 21 May 2016 19:07:58 -0500 [thread overview]
Message-ID: <20160522000756.GA9591@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq37pchi90.fsf@gitster.mtv.corp.google.com>
On Fri, May 20, 2016 at 08:16:43AM -0700, Junio C Hamano wrote:
> > Acked-by: Jeff King <peff@peff.net>
>
> I didn't see him acking this exact version, so if you didn't include
> this line here, I would have missed it. Thanks.
I don't think I ever saw an actual patch to ack until now; I just said
the idea seemed good.
That being said, the patch _does_ look good, and I am fine to have my
ack/reviewed-by on it (though I agree with your points regarding the
commit message).
-Peff
prev parent reply other threads:[~2016-05-22 0:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 14:31 [PATCH] t0008: 4 tests fail with ksh88 Armin Kunaschik
2016-05-20 15:16 ` Junio C Hamano
2016-05-20 16:10 ` Junio C Hamano
2016-05-20 16:14 ` Armin Kunaschik
2016-05-20 21:01 ` Christian Couder
2016-05-20 16:11 ` Armin Kunaschik
2016-05-22 0:07 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160522000756.GA9591@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=megabreit@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).