From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org, sandals@crustytoothpaste.net
Subject: Re: [PATCH v1 0/3] travis-ci: build docs with asciidoctor
Date: Thu, 13 Apr 2017 15:41:00 -0700 [thread overview]
Message-ID: <xmqq37dcorr7.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170411083309.58315-1-larsxschneider@gmail.com> (Lars Schneider's message of "Tue, 11 Apr 2017 10:33:06 +0200")
Lars Schneider <larsxschneider@gmail.com> writes:
> this is a mini series to build the documentation with asciidoctor in
> addition to asciidoc on Travis-CI.
Overall, this looks sensible. I didn't spot anything questionable
other than a minor style nit, i.e. write these
make doc USE_ASCIIDOCTOR=1
make -j2 doc USE_ASCIIDOCTOR=1
more like this
make USE_ASCIIDOCTOR=1 doc
make -j2 USE_ASCIIDOCTOR=1 doc
Having said that, I wonder if we get some interesting results out of
building the documentation twice, though. By looking at the Travis
log with timestamps, we probably can see how long each build takes,
but that is much less interesting than learning if new versions of
text used mark-up that does not format correctly on one or the other
(i.e. catch documentation breakage early in each CI run), for
example. I have an impression that neither AsciiDoc nor AsciiDoctor
"fails" in an obvious way that "make" can notice (i.e. they often
just silently produce nonsense output when fed a malformed input
instead).
Thanks.
next prev parent reply other threads:[~2017-04-13 22:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 8:33 [PATCH v1 0/3] travis-ci: build docs with asciidoctor Lars Schneider
2017-04-11 8:33 ` [PATCH v1 1/3] travis-ci: build documentation with AsciiDoc and Asciidoctor Lars Schneider
2017-04-11 8:33 ` [PATCH v1 2/3] travis-ci: parallelize documentation build Lars Schneider
2017-04-11 8:33 ` [PATCH v1 3/3] travis-ci: unset compiler for jobs that do not need one Lars Schneider
2017-04-13 22:41 ` Junio C Hamano [this message]
2017-04-18 8:32 ` [PATCH v1 0/3] travis-ci: build docs with asciidoctor Lars Schneider
2017-04-18 10:44 ` brian m. carlson
2017-04-18 15:03 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37dcorr7.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).