git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Lars Schneider <larsxschneider@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v1 0/3] travis-ci: build docs with asciidoctor
Date: Tue, 18 Apr 2017 17:03:50 +0200	[thread overview]
Message-ID: <D9F45212-91F7-4BB1-A0EC-74A84DA81860@gmail.com> (raw)
In-Reply-To: <20170418104411.hdkzh3psvej63tqw@genre.crustytoothpaste.net>


> On 18. Apr 2017, at 12:44, brian m. carlson <sandals@crustytoothpaste.net> wrote:
> 
>> On Tue, Apr 18, 2017 at 10:32:59AM +0200, Lars Schneider wrote:
>> 
>>> On 14. Apr 2017, at 00:41, Junio C Hamano <gitster@pobox.com> wrote:
>>> Having said that, I wonder if we get some interesting results out of
>>> building the documentation twice, though.  By looking at the Travis
>>> log with timestamps, we probably can see how long each build takes,
>>> but that is much less interesting than learning if new versions of
>>> text used mark-up that does not format correctly on one or the other
>>> (i.e. catch documentation breakage early in each CI run), for
>>> example.  I have an impression that neither AsciiDoc nor AsciiDoctor
>>> "fails" in an obvious way that "make" can notice (i.e. they often
>>> just silently produce nonsense output when fed a malformed input
>>> instead).
>> 
>> True! But wouldn't we get a syntax check here? Wouldn't asciidoc / ascidoctor bark if we use wrong/unsupported elements?
> 
> Asciidoctor isn't very strict about questionable items.  If you want
> that behavior, you'd want to check for output to standard error during
> the make process, as Asciidoctor uses Ruby's warn function.

That sounds good. I'll check stderr in the next iteration!

Thanks,
Lars

      reply	other threads:[~2017-04-18 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11  8:33 [PATCH v1 0/3] travis-ci: build docs with asciidoctor Lars Schneider
2017-04-11  8:33 ` [PATCH v1 1/3] travis-ci: build documentation with AsciiDoc and Asciidoctor Lars Schneider
2017-04-11  8:33 ` [PATCH v1 2/3] travis-ci: parallelize documentation build Lars Schneider
2017-04-11  8:33 ` [PATCH v1 3/3] travis-ci: unset compiler for jobs that do not need one Lars Schneider
2017-04-13 22:41 ` [PATCH v1 0/3] travis-ci: build docs with asciidoctor Junio C Hamano
2017-04-18  8:32   ` Lars Schneider
2017-04-18 10:44     ` brian m. carlson
2017-04-18 15:03       ` Lars Schneider [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9F45212-91F7-4BB1-A0EC-74A84DA81860@gmail.com \
    --to=larsxschneider@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).