From: Junio C Hamano <gitster@pobox.com>
To: Andreas Heiduk <asheiduk@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Lars Schneider" <larsxschneider@gmail.com>,
"Philip Oakley" <philipoakley@iee.org>,
"Git Mailing List" <git@vger.kernel.org>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v1] Configure Git contribution guidelines for github.com
Date: Thu, 15 Jun 2017 10:59:11 -0700 [thread overview]
Message-ID: <xmqq37b12kuo.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <6e0de364-97a4-a2c1-eaea-8e9931cce6b5@gmail.com> (Andreas Heiduk's message of "Thu, 15 Jun 2017 19:31:51 +0200")
Andreas Heiduk <asheiduk@gmail.com> writes:
> Am 15.06.2017 um 18:43 schrieb Junio C Hamano:
>> Another thing that may regress that you did not mention is that we
>> would lose a convenient way to _count_ proposed changes coming via
>> submitGit (i.e. you can simply go to the pull-request page), so that
>> the number can be compared with the number of proposed changes
>> directly made on the mailing list, which would be a good way to
>> gauge how submitGit service is helping our community. But even for
>> that, you'd need to go to the list to find the denominator
>> (i.e. total number of changes proposed), and by the time you do
>> that, counting the numerator (i.e. those come via submitGit) by
>> finding the telltale sign submitGit leaves in its output among these
>> denominator messages should be trivial.
>
> This numbers can be aquired quite easily if submitGit adds a defined
> trailer to the converted commit message like this:
>
> Signed-off-by: Foo Bar <foo@bar>
> Submit-git-id: url-or-id-of-pr
I do not think you would want the noise _in_ the log message. The
"telltale sign" I had in mind was these "signature" lines at the end
of the message:
--
https://github.com/git/git/pull/538
next prev parent reply other threads:[~2017-06-15 17:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 14:21 [PATCH v1] Configure Git contribution guidelines for github.com Lars Schneider
2017-06-09 16:18 ` Ævar Arnfjörð Bjarmason
2017-06-09 16:29 ` Lars Schneider
2017-06-10 1:44 ` Junio C Hamano
2017-06-09 17:03 ` Jonathan Nieder
2017-06-10 1:51 ` Junio C Hamano
2017-06-13 7:57 ` Lars Schneider
2017-06-10 7:35 ` Jeff King
2017-06-13 7:51 ` Lars Schneider
2017-06-10 12:48 ` Philip Oakley
2017-06-12 15:52 ` Junio C Hamano
2017-06-13 7:45 ` Lars Schneider
2017-06-15 8:09 ` Ævar Arnfjörð Bjarmason
2017-06-15 16:43 ` Junio C Hamano
2017-06-15 17:31 ` Andreas Heiduk
2017-06-15 17:59 ` Junio C Hamano [this message]
2017-06-13 7:48 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37b12kuo.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=asheiduk@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).