From: Lars Schneider <larsxschneider@gmail.com>
To: Philip Oakley <philipoakley@iee.org>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net
Subject: Re: [PATCH v1] Configure Git contribution guidelines for github.com
Date: Tue, 13 Jun 2017 09:48:55 +0200 [thread overview]
Message-ID: <A712386E-0C4B-4A6C-B231-EA52FA285F34@gmail.com> (raw)
In-Reply-To: <31A456B20D984421AA958A39B2FCD29D@PhilipOakley>
> On 10 Jun 2017, at 14:48, Philip Oakley <philipoakley@iee.org> wrote:
>
> From: "Lars Schneider" <larsxschneider@gmail.com>
>> Many open source projects use github.com for their contribution process.
>> Although we mirror the Git core repository to github.com [1] we do not
>> use any other github.com service. This is unknown/unexpected to a
>> number of (potential) contributors and consequently they create Pull
>> Requests against our mirror with their contributions. These Pull
>> Requests become stall [2]. This is frustrating to them as they think we
>> ignore them and it is also unsatisfactory for us as we miss potential
>> code improvements and/or new contributors.
>>
>> GitHub offers a way to notify Pull Request contributors about the
>> contribution guidelines for a project [3]. Let's make use of this!
>>
>> [1] https://github.com/git/git
>> [2] https://github.com/git/git/pulls
>> [3] https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/
>>
>> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
>> ---
>
> I see there are currently 84 open PRs (13 in the last 14 days), so it is real.
>
> I also see that the Issues page for git.git appears to be disabled, and will redirect to the pulls page.
>
> Maybe the instructions should also be part of an Issues template which could reduce the potential number of PRs being created (but could create its own problems)
I don't think that is necessary as Issues are disabled for this repo.
>> ...
>> +Thanks for taking the time to contribute to Git! Please be advised, that the Git community does not use github.com for their contributions. Instead, we use a [mailing list](http://public-inbox.org/git/) for code submissions, code reviews, and bug reports.
>
> Isn't the mailing list git@vger.kernel.org, with an archive at http://public-inbox.org/git/ ?
Agreed!
>
>> +
>> +Please [read the maintainer notes](http://repo.or.cz/w/git.git?a=blob_plain;f=MaintNotes;hb=todo) to learn how the Git
>
> Is using the repo.or.cz address deliberate as a way of highlighting that Github isn't the centre of the universe when accessing a DVCS repo?
Haha, partly yes. Plus, I wasn't able to figure out quickly how to access the todo blob on GitHub.
> Maybe the kernel.org repo should be first, or at least the alt-git.git repo at repo.or.cz listed in those same notes.
Agreed!
> It's still a good idea though.
Thanks :)
- Lars
prev parent reply other threads:[~2017-06-13 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 14:21 [PATCH v1] Configure Git contribution guidelines for github.com Lars Schneider
2017-06-09 16:18 ` Ævar Arnfjörð Bjarmason
2017-06-09 16:29 ` Lars Schneider
2017-06-10 1:44 ` Junio C Hamano
2017-06-09 17:03 ` Jonathan Nieder
2017-06-10 1:51 ` Junio C Hamano
2017-06-13 7:57 ` Lars Schneider
2017-06-10 7:35 ` Jeff King
2017-06-13 7:51 ` Lars Schneider
2017-06-10 12:48 ` Philip Oakley
2017-06-12 15:52 ` Junio C Hamano
2017-06-13 7:45 ` Lars Schneider
2017-06-15 8:09 ` Ævar Arnfjörð Bjarmason
2017-06-15 16:43 ` Junio C Hamano
2017-06-15 17:31 ` Andreas Heiduk
2017-06-15 17:59 ` Junio C Hamano
2017-06-13 7:48 ` Lars Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A712386E-0C4B-4A6C-B231-EA52FA285F34@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).