From: Junio C Hamano <gitster@pobox.com>
To: Luis Marsano <luis.marsano@gmail.com>
Cc: git@vger.kernel.org, Ted Zlatanov <tzz@lifelogs.com>
Subject: Re: [PATCH 2/2] git-credential-netrc: accept gpg option
Date: Thu, 10 May 2018 18:57:24 +0900 [thread overview]
Message-ID: <xmqq36yzkf3v.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180509213634.5198-3-luis.marsano@gmail.com> (Luis Marsano's message of "Wed, 9 May 2018 17:36:34 -0400")
Luis Marsano <luis.marsano@gmail.com> writes:
> git-credential-netrc was hardcoded to decrypt with 'gpg' regardless of the gpg.program option
> this now uses the gpg command option if set, else, the gpg.program option set in the git repository or global configuration, else defaults to 'gpg'
> for git-credential-netrc
These lines are way overlong. Wrap at around 72-78 cols, perhaps.
Complete each sentence with a full-stop.
> - use Git.pm for repository and global option queries
> - add -g|--gpg command option & document it in command usage
> - test repository & command options
> - support unicode
There are other changes that are not explained/justified here, I
think.
- Instead of ALLCAPS as a placeholder for a command line argument in
the help text, use <placeholder>, because doing so is better due
to such and such reasons.
I think it is good to consistently do so, but it is unclear why
ALLCAPS is bad and <placeholder> is better. That needs to be
explained.
- Replace three-dots in the help text with U+2026 to punish those
who are still using unicode-inapable terminal in this century.
I do not think this part of the patch is a good idea at all, but
perhaps I misunderstood the reason behind this change you had in
mind (as you did not explain it in the proposed log message).
> @@ -62,27 +69,31 @@ if ($options{help}) {
>
> print <<EOHIPPUS;
>
> -$0 [-f AUTHFILE1] [-f AUTHFILEN] [-d] [-v] [-k] get
> +$0 [(-f <authfile>)…] [-g <program>] [-d] [-v] [-k] get
Is this a desired change, or unwanted change left in the patch by
accident?
> -...and if you want lots of debugging info:
> +…and if you want lots of debugging info:
Is this a desired change, or unwanted change left in the patch by
accident?
>
> git config credential.helper '$shortname -f AUTHFILE -d'
>
> -...or to see the files opened and data found:
> +…or to see the files opened and data found:
>
Ditto.
> git config credential.helper '$shortname -f AUTHFILE -v'
>
> -Only "get" mode is supported by this credential helper. It opens every AUTHFILE
> +Only "get" mode is supported by this credential helper. It opens every <authfile>
> and looks for the first entry that matches the requested search criteria:
>
> 'port|protocol':
> @@ -120,7 +131,7 @@ host=github.com
> protocol=https
> username=tzz
>
> -this credential helper will look for the first entry in every AUTHFILE that
> +this credential helper will look for the first entry in every <authfile> that
> matches
>
> machine github.com port https login tzz
> @@ -129,7 +140,7 @@ OR
>
> machine github.com protocol https login tzz
>
> -OR... etc. acceptable tokens as listed above. Any unknown tokens are
> +OR… etc. acceptable tokens as listed above. Any unknown tokens are
Ditto.
> # Credentials must get a parameter, so die if it's missing.
> -die "Syntax: $0 [-f AUTHFILE1] [-f AUTHFILEN] [-d] get" unless defined $mode;
> +die "Syntax: $0 [(-f <authfile>)…] [-d] get" unless defined $mode;
Ditto.
next prev parent reply other threads:[~2018-05-10 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 21:36 [PATCH 0/2] Configurable GnuPG command for git-credential-netrc Luis Marsano
2018-05-09 21:36 ` [PATCH 1/2] git-credential-netrc: adapt to test framework for git Luis Marsano
2018-05-10 9:43 ` Junio C Hamano
2018-05-14 9:46 ` Luis Marsano
2018-05-09 21:36 ` [PATCH 2/2] git-credential-netrc: accept gpg option Luis Marsano
2018-05-10 9:57 ` Junio C Hamano [this message]
2018-05-14 10:20 ` Luis Marsano
2018-05-12 9:17 ` [PATCH v2 0/2] Configurable GnuPG command for git-credential-netrc Luis Marsano
2018-05-12 9:17 ` [PATCH v2 1/2] git-credential-netrc: adapt to test framework for git Luis Marsano
2018-05-12 9:17 ` [PATCH v2 2/2] git-credential-netrc: accept gpg option Luis Marsano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq36yzkf3v.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=luis.marsano@gmail.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).