From: "Luis Marsano" <luis.marsano@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: <git@vger.kernel.org>, "Ted Zlatanov" <tzz@lifelogs.com>
Subject: Re: [PATCH 2/2] git-credential-netrc: accept gpg option
Date: Mon, 14 May 2018 06:20:24 -0400 [thread overview]
Message-ID: <20180514062024.5819@lmm-notebook.localdomain> (raw)
In-Reply-To: Your message of Thu, 10 May 2018 18:57:24 +0900 <xmqq36yzkf3v.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> wrote:
> Luis Marsano <luis.marsano@gmail.com> writes:
>
> > git-credential-netrc was hardcoded to decrypt with 'gpg' regardless of the gpg.program option
> > this now uses the gpg command option if set, else, the gpg.program option set in the git repository or global configuration, else defaults to 'gpg'
> > for git-credential-netrc
>
> These lines are way overlong. Wrap at around 72-78 cols, perhaps.
> Complete each sentence with a full-stop.
Thanks, corrected this in the updated patch https://public-inbox.org/git/20180512091728.4931-3-luis.marsano@gmail.com/.
> > - use Git.pm for repository and global option queries
> > - add -g|--gpg command option & document it in command usage
> > - test repository & command options
> > - support unicode
>
> There are other changes that are not explained/justified here, I
> think.
>
> - Instead of ALLCAPS as a placeholder for a command line argument in
> the help text, use <placeholder>, because doing so is better due
> to such and such reasons.
>
> I think it is good to consistently do so, but it is unclear why
> ALLCAPS is bad and <placeholder> is better. That needs to be
> explained.
Not necessarily bad, but the reason was to conform with Documentation/CodingGuidelines.
The updated commit message now explains this.
> - Replace three-dots in the help text with U+2026 to punish those
> who are still using unicode-inapable terminal in this century.
>
> I do not think this part of the patch is a good idea at all, but
> perhaps I misunderstood the reason behind this change you had in
> mind (as you did not explain it in the proposed log message).
The original intent for this was semantics & accessibility: screenreaders more reliably interpret … than ... as ellipsis, and I imagine other assistive technology would, too.
However, after research, I've learned there are better supported ways to go about it, so I'm retracting that change.
The updated patch https://public-inbox.org/git/20180512091728.4931-3-luis.marsano@gmail.com/ should reflect all corrections.
Thank you for the feedback, and please let me know of further issues.
next prev parent reply other threads:[~2018-05-14 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 21:36 [PATCH 0/2] Configurable GnuPG command for git-credential-netrc Luis Marsano
2018-05-09 21:36 ` [PATCH 1/2] git-credential-netrc: adapt to test framework for git Luis Marsano
2018-05-10 9:43 ` Junio C Hamano
2018-05-14 9:46 ` Luis Marsano
2018-05-09 21:36 ` [PATCH 2/2] git-credential-netrc: accept gpg option Luis Marsano
2018-05-10 9:57 ` Junio C Hamano
2018-05-14 10:20 ` Luis Marsano [this message]
2018-05-12 9:17 ` [PATCH v2 0/2] Configurable GnuPG command for git-credential-netrc Luis Marsano
2018-05-12 9:17 ` [PATCH v2 1/2] git-credential-netrc: adapt to test framework for git Luis Marsano
2018-05-12 9:17 ` [PATCH v2 2/2] git-credential-netrc: accept gpg option Luis Marsano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514062024.5819@lmm-notebook.localdomain \
--to=luis.marsano@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).