* [PATCH v2 2/2] git-C: Add test to check "git -C ''"
@ 2015-03-05 10:57 Karthik Nayak
2015-03-05 11:02 ` karthik nayak
2015-03-05 21:39 ` Junio C Hamano
0 siblings, 2 replies; 4+ messages in thread
From: Karthik Nayak @ 2015-03-05 10:57 UTC (permalink / raw)
To: git; +Cc: Karthik Nayak
Add a test to check whether "git -C ''" works
without giving an error. This is achieved by
adding a commit and checking the log using
"git -C ''" and comparing the log message with
the commit message.
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
t/t0056-git-C.sh | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/t/t0056-git-C.sh b/t/t0056-git-C.sh
index 99c0377..1cefd4a 100755
--- a/t/t0056-git-C.sh
+++ b/t/t0056-git-C.sh
@@ -1,3 +1,4 @@
+
#!/bin/sh
test_description='"-C <path>" option and its effects on other path-related options'
@@ -81,4 +82,13 @@ test_expect_success 'Relative followed by fullpath: "-C ./here -C /there" is equ
test_cmp expected actual
'
+test_expect_success 'Should not barf when "git -C "" cmd" is used' '
+ echo 1 > a.txt &&
+ msg="initial a.txt" &&
+ (git add a.txt && git commit -m "$msg") &&
+ echo "$msg" >expected &&
+ git -C "" log --format=%s >actual &&
+ test_cmp expected actual
+'
+
test_done
--
2.3.1.167.g7f4ba4b.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] git-C: Add test to check "git -C ''"
2015-03-05 10:57 [PATCH v2 2/2] git-C: Add test to check "git -C ''" Karthik Nayak
@ 2015-03-05 11:02 ` karthik nayak
2015-03-05 21:39 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: karthik nayak @ 2015-03-05 11:02 UTC (permalink / raw)
To: Karthik Nayak; +Cc: git
On 03/05/2015 04:27 PM, Karthik Nayak wrote:
> Add a test to check whether "git -C ''" works
> without giving an error. This is achieved by
> adding a commit and checking the log using
> "git -C ''" and comparing the log message with
> the commit message.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
> t/t0056-git-C.sh | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/t/t0056-git-C.sh b/t/t0056-git-C.sh
> index 99c0377..1cefd4a 100755
> --- a/t/t0056-git-C.sh
> +++ b/t/t0056-git-C.sh
> @@ -1,3 +1,4 @@
> +
> #!/bin/sh
>
> test_description='"-C <path>" option and its effects on other path-related options'
> @@ -81,4 +82,13 @@ test_expect_success 'Relative followed by fullpath: "-C ./here -C /there" is equ
> test_cmp expected actual
> '
>
> +test_expect_success 'Should not barf when "git -C "" cmd" is used' '
> + echo 1 > a.txt &&
> + msg="initial a.txt" &&
> + (git add a.txt && git commit -m "$msg") &&
> + echo "$msg" >expected &&
> + git -C "" log --format=%s >actual &&
> + test_cmp expected actual
> +'
> +
> test_done
>
Ignore This, Didnt connect it to the first patch!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] git-C: Add test to check "git -C ''"
2015-03-05 10:56 [PATCH v2 1/2] git: make "git -C '' <cmd>" not to barf Karthik Nayak
@ 2015-03-05 11:03 ` Karthik Nayak
0 siblings, 0 replies; 4+ messages in thread
From: Karthik Nayak @ 2015-03-05 11:03 UTC (permalink / raw)
To: git; +Cc: Karthik Nayak
Add a test to check whether "git -C ''" works
without giving an error. This is achieved by
adding a commit and checking the log using
"git -C ''" and comparing the log message with
the commit message.
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
t/t0056-git-C.sh | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/t/t0056-git-C.sh b/t/t0056-git-C.sh
index 99c0377..1cefd4a 100755
--- a/t/t0056-git-C.sh
+++ b/t/t0056-git-C.sh
@@ -1,3 +1,4 @@
+
#!/bin/sh
test_description='"-C <path>" option and its effects on other path-related options'
@@ -81,4 +82,13 @@ test_expect_success 'Relative followed by fullpath: "-C ./here -C /there" is equ
test_cmp expected actual
'
+test_expect_success 'Should not barf when "git -C "" cmd" is used' '
+ echo 1 > a.txt &&
+ msg="initial a.txt" &&
+ (git add a.txt && git commit -m "$msg") &&
+ echo "$msg" >expected &&
+ git -C "" log --format=%s >actual &&
+ test_cmp expected actual
+'
+
test_done
--
2.3.1.167.g7f4ba4b.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] git-C: Add test to check "git -C ''"
2015-03-05 10:57 [PATCH v2 2/2] git-C: Add test to check "git -C ''" Karthik Nayak
2015-03-05 11:02 ` karthik nayak
@ 2015-03-05 21:39 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2015-03-05 21:39 UTC (permalink / raw)
To: Karthik Nayak; +Cc: git
Karthik Nayak <karthik.188@gmail.com> writes:
> Add a test to check whether "git -C ''" works without giving an
> error. This is achieved by adding a commit and checking the log
> using "git -C ''" and comparing the log message with the commit
> message.
Why choose something complex like commit and log, though?
Wouldn't something like this match the series of current tests
better? Also I think a small change with a small test like these
should be in a single patch, not two separate ones.
Thanks.
t/t0056-git-C.sh | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/t/t0056-git-C.sh b/t/t0056-git-C.sh
index 99c0377..551d806 100755
--- a/t/t0056-git-C.sh
+++ b/t/t0056-git-C.sh
@@ -14,6 +14,16 @@ test_expect_success '"git -C <path>" runs git from the directory <path>' '
test_cmp expected actual
'
+test_expect_success '"git -C <path>" with an empty <path> is a no-op' '
+ (
+ mkdir -p dir1/subdir &&
+ cd dir1/subdir &&
+ git -C "" rev-parse --show-prefix >actual &&
+ echo subdir/ >expect
+ test_cmp expect actual
+ )
+'
+
test_expect_success 'Multiple -C options: "-C dir1 -C dir2" is equivalent to "-C dir1/dir2"' '
test_create_repo dir1/dir2 &&
echo 1 >dir1/dir2/b.txt &&
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-05 21:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 10:57 [PATCH v2 2/2] git-C: Add test to check "git -C ''" Karthik Nayak
2015-03-05 11:02 ` karthik nayak
2015-03-05 21:39 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2015-03-05 10:56 [PATCH v2 1/2] git: make "git -C '' <cmd>" not to barf Karthik Nayak
2015-03-05 11:03 ` [PATCH v2 2/2] git-C: Add test to check "git -C ''" Karthik Nayak
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).