From: Junio C Hamano <gitster@pobox.com>
To: Matthew DeVore <matvore@google.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrn@google.com>,
matvore@comcast.net, dstolee@microsoft.com, pclouds@gmail.com,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] terminology tweak: prune -> path limiting
Date: Tue, 11 Dec 2018 10:40:25 +0900 [thread overview]
Message-ID: <xmqq1s6oon7a.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAMfpvhKh3xewUY-g9oVJq1o=G3w9EspoQUHc1edHUx3AD4OWfg@mail.gmail.com> (Matthew DeVore's message of "Mon, 10 Dec 2018 10:57:28 -0800")
Matthew DeVore <matvore@google.com> writes:
> When I tried to figure out what "prune" and "prune_data" ("data" is
> quite vague, so these two fields read like "prune_1" and "prune_2")
> referred to in "revision.h",...
It was unfortunate that 8efdc326 ("rev-lib: Make it easy to do
rename tracking (take 2)", 2006-03-10) had to rename "paths" to
"prune_data" when attempting to generalize the history
simplification mechanism by introducing "prune_fn", which can be
used instead of a fixed function, and as one half of the pair, "data
used by the prune function" made some sense.
When we partially reverted that over-generalization with 53b2c823
("revision walker: mini clean-up", 2007-11-05), we probably should
have changed the prune_data back to paths, but we didn't. Worse
yet, when we made prune_data from a void pointer to struct pathspec
at afe069d1 ("struct rev_info: convert prune_data to struct
pathspec", 2010-12-17), we really should have renamed it back to
paths, but we didn't.
So I think it is a good idea to get rid of prune_data and make it
clear it is no longer a generic thing but cannot be anything but a
pathspec. I am not sure what the bit should be called, though. It
is a bit to enable any history simplification and not limited to
pathspec limiting (e.g. simplify-by-decoration enables it, too).
next prev parent reply other threads:[~2018-12-11 1:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 21:33 [PATCH] terminology tweak: prune -> path limiting Matthew DeVore
2018-12-09 1:36 ` Junio C Hamano
2018-12-09 1:52 ` Junio C Hamano
2018-12-10 18:57 ` Matthew DeVore
2018-12-11 1:40 ` Junio C Hamano [this message]
2018-12-11 5:16 ` MATTHEW DEVORE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1s6oon7a.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=jrn@google.com \
--cc=matvore@comcast.net \
--cc=matvore@google.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).