git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthew DeVore <matvore@google.com>
Cc: git@vger.kernel.org, jrn@google.com, matvore@comcast.net,
	dstolee@microsoft.com, pclouds@gmail.com, peff@peff.net
Subject: Re: [PATCH] terminology tweak: prune -> path limiting
Date: Sun, 09 Dec 2018 10:36:07 +0900	[thread overview]
Message-ID: <xmqqo99v5vnc.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181206213315.64423-1-matvore@google.com> (Matthew DeVore's message of "Thu, 6 Dec 2018 13:33:15 -0800")

Matthew DeVore <matvore@google.com> writes:

> In the codebase, "prune" is a highly overloaded term, and it caused me a
> lot of trouble to figure out what it meant when it was used in the
> context of path limiting. Stop using the word "prune" when we really
> mean "path limiting."

path limiting is also used for two purposes.  "pruning", which is to
cull the side branches that do not contribute the changes made to
the paths we are interested in, and showing only the changes to the
paths that match pathspec.

AFAIK, "prune" is also used to describe unreachable loose objects,
but that use is fairly isolated and have little risk of being
confusing too much.  Are there other uses to make you consider it
"highly overloaded"?

My gut feeling is that the result is not reducing "overloading" in a
meaningful way, and this change is not worth the churn, but it
depends on the answer to the above question.

Thanks.

  reply	other threads:[~2018-12-09  1:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 21:33 [PATCH] terminology tweak: prune -> path limiting Matthew DeVore
2018-12-09  1:36 ` Junio C Hamano [this message]
2018-12-09  1:52   ` Junio C Hamano
2018-12-10 18:57   ` Matthew DeVore
2018-12-11  1:40     ` Junio C Hamano
2018-12-11  5:16       ` MATTHEW DEVORE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo99v5vnc.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=jrn@google.com \
    --cc=matvore@comcast.net \
    --cc=matvore@google.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).