git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git <git@vger.kernel.org>,
	Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH v5 03/11] ref-filter: add option to pad atoms to the right
Date: Mon, 27 Jul 2015 20:47:32 +0200	[thread overview]
Message-ID: <vpqwpxl30aj.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAOLa=ZRVMnqxb-E29f_53igzJDTWNU0yjVACSq1CK8TCbaM-9w@mail.gmail.com> (Karthik Nayak's message of "Tue, 28 Jul 2015 00:12:24 +0530")

Karthik Nayak <karthik.188@gmail.com> writes:

> On Mon, Jul 27, 2015 at 9:24 PM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Yes, but on the other hand we already have:
>>
>>   git log --format='%<|(50)A very long irrevlevancy|%an|'
>>
>> that pads/truncate %an. So, consistancy would dictate that Karthik's
>> version is the right one.
>
> Sorry but I didn't understand what you're trying to say here, Matthieu.

The "git log" equivalent of %(padright:N) is %<|(N), and it behaves the
same way as your current implementation of %(padright) (except for the
missing reset in your v5).

So, if we want to be consistant with "git log", we should keep the
"apply to next atom, even if it's far away in the format string"
semantics.

Note that consistancy is not the only criterion for choice, so I'm not
saying we should absolutely do this, just that there's an argument in
favor of it.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2015-07-27 18:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27  7:26 [PATCH v5 00/11] port tag.c to use ref-filter APIs Karthik Nayak
2015-07-27  7:27 ` [PATCH v5 01/11] ref-filter: introduce 'ref_formatting_state' Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 02/11] ref-filter: make `color` use `ref_formatting_state` Karthik Nayak
2015-07-27 12:47     ` Matthieu Moy
2015-07-27 14:28       ` Junio C Hamano
2015-07-27 17:23         ` Karthik Nayak
2015-07-27 16:02       ` Karthik Nayak
2015-07-27 13:06     ` Matthieu Moy
2015-07-27 17:16       ` Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 03/11] ref-filter: add option to pad atoms to the right Karthik Nayak
2015-07-27 12:50     ` Matthieu Moy
2015-07-27 15:45       ` Junio C Hamano
2015-07-27 15:54         ` Matthieu Moy
2015-07-27 18:42           ` Karthik Nayak
2015-07-27 18:47             ` Matthieu Moy [this message]
2015-07-27 18:54               ` Karthik Nayak
2015-07-27 18:56           ` Junio C Hamano
2015-07-27 18:43       ` Karthik Nayak
2015-07-28 21:41     ` Eric Sunshine
2015-07-29 16:16       ` Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 04/11] ref-filter: add option to filter only tags Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 05/11] ref-filter: support printing N lines from tag annotation Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 06/11] ref-filter: add support to sort by version Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 07/11] ref-filter: add option to match literal pattern Karthik Nayak
2015-07-27 12:54     ` Matthieu Moy
2015-07-27 15:57       ` Karthik Nayak
2015-07-27 15:59         ` Karthik Nayak
2015-07-27 16:06           ` Matthieu Moy
2015-07-27 16:48             ` Karthik Nayak
2015-07-28 21:49     ` Eric Sunshine
2015-07-29 16:17       ` Karthik Nayak
2015-07-30 11:21       ` Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 08/11] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 09/11] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 10/11] tag.c: implement '--format' option Karthik Nayak
2015-07-27  7:27   ` [PATCH v5 11/11] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-27 12:42   ` [PATCH v5 01/11] ref-filter: introduce 'ref_formatting_state' Matthieu Moy
2015-07-27 15:28     ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqwpxl30aj.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).