git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <stefanbeller@googlemail.com>, git@vger.kernel.org
Subject: Re: Bugreport on Ubuntu LTS: not ok - 2 Objects creation does not break ACLs with restrictive umask
Date: Tue, 05 Jun 2012 08:02:55 +0200	[thread overview]
Message-ID: <vpqpq9ejnxs.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vy5o2ra7w.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 04 Jun 2012 15:19:47 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Stefan Beller <stefanbeller@googlemail.com> writes:
>
>> I tried debugging into it:
>> In git/t/t1304-default-acl.sh there is:
>> check_perms_and_acl () {
>>     test -r "$1" &&
>>     getfacl "$1" > actual &&
>>     grep -q "user:root:rwx" actual &&
>>     grep -q "user:${LOGNAME}:rwx" actual &&
>>     egrep "mask::?r--" actual > /dev/null 2>&1 &&
>>     grep -q "group::---" actual || false
>> }

Can you run it with --verbose and post the result?

> Any ideas (other than "Your filesystem is broken",
> that is)?

I'm very tempted to go for the "Your filesystem is broken" indeed.

> As far as I can tell, with 'mask::---', these specific users who are
> given permissions to read from the objects wouldn't be able to read
> from them, so...

That's my understanding too.

Stefan, which filesystem are you using in the directory where you run
tests (type "mount" if you don't know)? Are you running on a virtual
machine?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2012-06-05  6:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-04 15:40 Bugreport on Ubuntu LTS: not ok - 2 Objects creation does not break ACLs with restrictive umask Stefan Beller
2012-06-04 20:18 ` Junio C Hamano
     [not found]   ` <CALbm-EatNCPjFRO4NyGfZuSa72-FXwZcd_7cFe-f_iMOdGL4MQ@mail.gmail.com>
2012-06-04 22:19     ` Junio C Hamano
2012-06-05  6:02       ` Matthieu Moy [this message]
2012-06-05  7:23         ` Stefan Beller
2012-06-05  7:43           ` Stefan Beller
2012-06-05  7:56           ` Jeff King
2012-06-05 11:29             ` Matthieu Moy
2012-06-05 12:23               ` Stefan Beller
2012-06-05 13:28                 ` Matthieu Moy
2012-06-05 14:04                   ` Jeff King
2012-06-05 14:10                     ` Jeff King
2012-06-05 14:28                       ` Jeff King
2012-06-05 15:05                         ` Jeff King
2012-06-05 16:31                           ` Junio C Hamano
2012-06-05 16:44                             ` Jeff King
2012-06-05 17:27                               ` Junio C Hamano
2012-06-06 13:28                                 ` [PATCH] t1304: improve setfacl prerequisite setup Jeff King
2012-06-06 16:11                                   ` Stefan Beller
2012-06-06 16:58                                   ` Junio C Hamano
2012-06-07  9:02                                     ` Jeff King
2012-06-07 16:16                                       ` Junio C Hamano
2012-06-08  1:18                                         ` Brandon Casey
2012-06-05 19:16                               ` Bugreport on Ubuntu LTS: not ok - 2 Objects creation does not break ACLs with restrictive umask Tyler Hicks
2012-06-05 20:45                                 ` Stefan Beller
2012-06-05 13:29                 ` Jeff King
  -- strict thread matches above, loose matches on Subject: below --
2012-06-04 20:49 Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqpq9ejnxs.fsf@bauges.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stefanbeller@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).