From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <stefanbeller@googlemail.com>
Cc: git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: Re: Bugreport on Ubuntu LTS: not ok - 2 Objects creation does not break ACLs with restrictive umask
Date: Mon, 04 Jun 2012 15:19:47 -0700 [thread overview]
Message-ID: <7vy5o2ra7w.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CALbm-EatNCPjFRO4NyGfZuSa72-FXwZcd_7cFe-f_iMOdGL4MQ@mail.gmail.com> (Stefan Beller's message of "Mon, 4 Jun 2012 22:48:30 +0200")
Stefan Beller <stefanbeller@googlemail.com> writes:
> I tried debugging into it:
> In git/t/t1304-default-acl.sh there is:
> check_perms_and_acl () {
> test -r "$1" &&
> getfacl "$1" > actual &&
> grep -q "user:root:rwx" actual &&
> grep -q "user:${LOGNAME}:rwx" actual &&
> egrep "mask::?r--" actual > /dev/null 2>&1 &&
> grep -q "group::---" actual || false
> }
>
> but when I do all the commands as in the test2:
> test_expect_success SETFACL 'Objects creation does not break ACLs with
> restrictive umask' '
> # SHA1 for empty blob
> check_perms_and_acl .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391
> '
> Now I run the second line in check_perms_and_acl () with
> .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391
> there is
>
> getfacl .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391
> # file: .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391
> # owner: sb
> # group: sb
> user::r--
> user:root:rwx #effective:---
> user:sb:rwx #effective:---
> group::---
> mask::---
> other::---
>
> This command seem to fail 'egrep "mask::?r--" actual' as there is
> mask::---
> but expected is
> mask::r--
>
> That's my understanding of the test case so far.
Hmph. Running the test manually does not seem to fail for me and
gives the "r--" mask.
I am lost. Matthieu, you introduced this as a failing test with
7aba618 (Add a testcase for ACL with restrictive umask.,
2010-02-22), as part of the series leading to 5256b00 (Use
git_mkstemp_mode instead of plain mkstemp to create object files,
2010-02-22). Any ideas (other than "Your filesystem is broken",
that is)? As far as I can tell, with 'mask::---', these specific
users who are given permissions to read from the objects wouldn't be
able to read from them, so...
next prev parent reply other threads:[~2012-06-04 22:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 15:40 Bugreport on Ubuntu LTS: not ok - 2 Objects creation does not break ACLs with restrictive umask Stefan Beller
2012-06-04 20:18 ` Junio C Hamano
[not found] ` <CALbm-EatNCPjFRO4NyGfZuSa72-FXwZcd_7cFe-f_iMOdGL4MQ@mail.gmail.com>
2012-06-04 22:19 ` Junio C Hamano [this message]
2012-06-05 6:02 ` Matthieu Moy
2012-06-05 7:23 ` Stefan Beller
2012-06-05 7:43 ` Stefan Beller
2012-06-05 7:56 ` Jeff King
2012-06-05 11:29 ` Matthieu Moy
2012-06-05 12:23 ` Stefan Beller
2012-06-05 13:28 ` Matthieu Moy
2012-06-05 14:04 ` Jeff King
2012-06-05 14:10 ` Jeff King
2012-06-05 14:28 ` Jeff King
2012-06-05 15:05 ` Jeff King
2012-06-05 16:31 ` Junio C Hamano
2012-06-05 16:44 ` Jeff King
2012-06-05 17:27 ` Junio C Hamano
2012-06-06 13:28 ` [PATCH] t1304: improve setfacl prerequisite setup Jeff King
2012-06-06 16:11 ` Stefan Beller
2012-06-06 16:58 ` Junio C Hamano
2012-06-07 9:02 ` Jeff King
2012-06-07 16:16 ` Junio C Hamano
2012-06-08 1:18 ` Brandon Casey
2012-06-05 19:16 ` Bugreport on Ubuntu LTS: not ok - 2 Objects creation does not break ACLs with restrictive umask Tyler Hicks
2012-06-05 20:45 ` Stefan Beller
2012-06-05 13:29 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2012-06-04 20:49 Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy5o2ra7w.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).