From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
avarab@gmail.com, gitster@pobox.com, git@vger.kernel.org,
Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH 2/2] git-rebase--interactive.sh: use printf instead of echo to print commit message
Date: Sun, 15 Aug 2010 10:56:21 +0200 [thread overview]
Message-ID: <vpqmxso45l6.fsf@bauges.imag.fr> (raw)
In-Reply-To: <4BE6DADC-6846-4942-B361-639DCD308F09@silverinsanity.com> (Brian Gernhardt's message of "Fri\, 13 Aug 2010 17\:34\:07 -0400")
Brian Gernhardt <benji@silverinsanity.com> writes:
> On Aug 13, 2010, at 4:47 PM, Brandon Casey wrote:
>
>> Replace the echo statements that operate on $rest with printf's to restore
>> what was lost from 938791cd. This avoids any mangling that XSI-conformant
>> echo's may introduce.
>
> ACK, this was exactly the problem. Thanks for the quick response!
Both patches sound good, yes.
Junio: I think you can either apply them on top of mine, or squash
them all together.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-08-15 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 16:37 git rebase -i exec merger broke t3404-rebase-interactive.sh Ævar Arnfjörð Bjarmason
2010-08-13 17:20 ` Brian Gernhardt
2010-08-13 20:47 ` [PATCH 1/2] git-rebase--interactive.sh: rework skip_unnecessary_picks Brandon Casey
2010-08-13 20:47 ` [PATCH 2/2] git-rebase--interactive.sh: use printf instead of echo to print commit message Brandon Casey
2010-08-13 21:34 ` Brian Gernhardt
2010-08-15 8:56 ` Matthieu Moy [this message]
2010-08-22 7:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqmxso45l6.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=avarab@gmail.com \
--cc=benji@silverinsanity.com \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).