git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Git Mailing List <git@vger.kernel.org>,
	Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: git rebase -i exec merger broke t3404-rebase-interactive.sh
Date: Fri, 13 Aug 2010 16:37:09 +0000	[thread overview]
Message-ID: <AANLkTinzBuR+9=+PwejJVwSkUiGODaP-RC7=agyLOgMt@mail.gmail.com> (raw)

39e388728 (merging git rebase -i exec support) broke the funny names
test in t3404-rebase-interactive.sh:

    expecting success:
            git rev-list A..funny >expect &&
            test_tick &&
            FAKE_LINES="1 2 3 4" git rebase -i A &&
            git rev-list A.. >actual &&
            test_cmp expect actual

    rebase -i script before editing:
    pick f6fec15 end with slash\
    pick 4f2ade4 something (\000) that looks like octal
    pick f95dfbf something (\n) that looks like a newline
    pick 0e82af6 another commit

    rebase -i script after editing:
    pick f6fec15 end with slash\
    pick 4f2ade4 something (\000) that looks like octal
    pick f95dfbf something (\n) that looks like a newline
    pick 0e82af6 another commit
    Unknown command: ) that looks like a newline
    Please fix this in the file /home/avar/g/git/t/trash
directory.t3404-rebase-interactive/.git/rebase-merge/git-rebase-todo.
    not ok - 50 rebase-i history with funny messages
    #
    #               git rev-list A..funny >expect &&
    #               test_tick &&
    #               FAKE_LINES="1 2 3 4" git rebase -i A &&
    #               git rev-list A.. >actual &&
    #               test_cmp expect actual
    #

This one breaks under bash too, does it work for you Matthieu? If so
what sort of environment are you executing it in?

             reply	other threads:[~2010-08-13 16:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13 16:37 Ævar Arnfjörð Bjarmason [this message]
2010-08-13 17:20 ` git rebase -i exec merger broke t3404-rebase-interactive.sh Brian Gernhardt
2010-08-13 20:47   ` [PATCH 1/2] git-rebase--interactive.sh: rework skip_unnecessary_picks Brandon Casey
2010-08-13 20:47   ` [PATCH 2/2] git-rebase--interactive.sh: use printf instead of echo to print commit message Brandon Casey
2010-08-13 21:34     ` Brian Gernhardt
2010-08-15  8:56       ` Matthieu Moy
2010-08-22  7:22     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTinzBuR+9=+PwejJVwSkUiGODaP-RC7=agyLOgMt@mail.gmail.com' \
    --to=avarab@gmail.com \
    --cc=Matthieu.Moy@imag.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).