From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Lawrence Siebert <lawrencesiebert@gmail.com>
Cc: git@vger.kernel.org,
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 3/4] log --count: added test
Date: Fri, 03 Jul 2015 11:16:51 +0200 [thread overview]
Message-ID: <vpqegkp38jg.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAKDoJU7MT5PkoPKaF=NYne0sgNfGC6q+y7+57L0135dgxKThgw@mail.gmail.com> (Lawrence Siebert's message of "Fri, 3 Jul 2015 01:30:44 -0700")
Lawrence Siebert <lawrencesiebert@gmail.com> writes:
> Ok, I'll fix that.
(Note: this is a typical example of why we don't top-post here. I made
several remarks and I can't know what "that" refers to)
(Meta-note: don't take the note as agressive, I know that top-posting is
the norm in many other places, I'm just giving you a glimpse of the
local culture ;-) ).
> If it's acceptable practice, I'll just squash everything I do on this
> feature and it's tests into one commit with a more detailed comment,
> and send the patch for that.
I think at least two patches are better: your PATCH 1 is a typical
preparation step, best reviewed alone in its own patch.
Splitting history into several patches is good, but each patch should
correspond to one logical step. Splitting code Vs doc Vs tests is
usually not the right way.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-07-03 9:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 23:50 [PATCH v2 0/4] git log --count Lawrence Siebert
2015-07-02 23:50 ` [PATCH v2 1/4] list-object: add get_commit_count function Lawrence Siebert
2015-07-03 7:24 ` Matthieu Moy
2015-07-03 8:09 ` Lawrence Siebert
2015-07-03 8:59 ` Matthieu Moy
2015-07-02 23:50 ` [PATCH v2 2/4] log: add --count option to git log Lawrence Siebert
2015-07-03 7:29 ` Matthieu Moy
2015-07-03 8:05 ` Lawrence Siebert
2015-07-03 9:16 ` Matthieu Moy
2015-07-02 23:50 ` [PATCH v2 3/4] log --count: added test Lawrence Siebert
2015-07-03 7:34 ` Matthieu Moy
2015-07-03 8:30 ` Lawrence Siebert
2015-07-03 9:16 ` Matthieu Moy [this message]
2015-07-03 9:54 ` Matthieu Moy
2015-07-04 0:57 ` Junio C Hamano
2015-07-04 0:54 ` Junio C Hamano
2015-07-02 23:50 ` [PATCH v2 4/4] git-log: update man documentation for --count Lawrence Siebert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqegkp38jg.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lawrencesiebert@gmail.com \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).