From: Lawrence Siebert <lawrencesiebert@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org,
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 1/4] list-object: add get_commit_count function
Date: Fri, 3 Jul 2015 01:09:39 -0700 [thread overview]
Message-ID: <CAKDoJU6DdSc2ux5vEJu2risW9a-cgJ7e5xBxysTFdYGMd+77Kw@mail.gmail.com> (raw)
In-Reply-To: <vpqlhex66v6.fsf@anie.imag.fr>
Mattieu,
Understood. I don't suppose there is any commonly code formatting tool
to automate formatting in the git style, is there?
Thanks,
Lawrence
On Fri, Jul 3, 2015 at 12:24 AM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Lawrence Siebert <lawrencesiebert@gmail.com> writes:
>
>> +void get_commit_count(struct rev_info * revs) {
>
> Please, write "struct rev_info *revs" (stick * to revs).
>
>> +void get_commit_count(struct rev_info * revs);
>
> Likewise.
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/
--
About Me: http://about.me/lawrencesiebert
Constantly Coding: http://constantcoding.blogspot.com
next prev parent reply other threads:[~2015-07-03 8:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 23:50 [PATCH v2 0/4] git log --count Lawrence Siebert
2015-07-02 23:50 ` [PATCH v2 1/4] list-object: add get_commit_count function Lawrence Siebert
2015-07-03 7:24 ` Matthieu Moy
2015-07-03 8:09 ` Lawrence Siebert [this message]
2015-07-03 8:59 ` Matthieu Moy
2015-07-02 23:50 ` [PATCH v2 2/4] log: add --count option to git log Lawrence Siebert
2015-07-03 7:29 ` Matthieu Moy
2015-07-03 8:05 ` Lawrence Siebert
2015-07-03 9:16 ` Matthieu Moy
2015-07-02 23:50 ` [PATCH v2 3/4] log --count: added test Lawrence Siebert
2015-07-03 7:34 ` Matthieu Moy
2015-07-03 8:30 ` Lawrence Siebert
2015-07-03 9:16 ` Matthieu Moy
2015-07-03 9:54 ` Matthieu Moy
2015-07-04 0:57 ` Junio C Hamano
2015-07-04 0:54 ` Junio C Hamano
2015-07-02 23:50 ` [PATCH v2 4/4] git-log: update man documentation for --count Lawrence Siebert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKDoJU6DdSc2ux5vEJu2risW9a-cgJ7e5xBxysTFdYGMd+77Kw@mail.gmail.com \
--to=lawrencesiebert@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).