From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Roberto Tyley <roberto.tyley@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
Robert Dailey <rcdailey.lists@gmail.com>,
Heiko Voigt <hvoigt@hvoigt.net>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Jens Lehmann <Jens.Lehmann@web.de>, Git <git@vger.kernel.org>,
Thomas Ferris Nicolaisen <tfnico@gmail.com>,
emma@gitforteams.com
Subject: Re: [Announce] submitGit for patch submission (was "Diffing submodule does not yield complete logs")
Date: Fri, 22 May 2015 18:14:07 +0200 [thread overview]
Message-ID: <vpqd21slhdc.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAFY1edY3+Wt-p2iQ5k64Fg-nMk2PmRSvhVkQSVNw94R18uPV2Q@mail.gmail.com> (Roberto Tyley's message of "Fri, 22 May 2015 09:33:20 +0100")
Roberto Tyley <roberto.tyley@gmail.com> writes:
> Hello, I'm stepping up to do that work :) Or at least, I'm implementing a
> one-way GitHub PR -> Mailing list tool, called submitGit:
>
> https://submitgit.herokuapp.com/
This is absolutely awsome. A few thoughts after testing the system to
send two patches:
* This is awesome :-). Really.
* I found no way to specify a version like [PATCH v2 ...]. Similarly,
there could be a way to say [RFC/PATCH ...].
* I'm used to 'git send-email' and I have an alias to add the --signoff
for me. I just sent a series where I forgot the signed-off-by. The
system could warn if I didn't signoff.
* I had a text+subject for the pull-request, I was expecting a cover
letter email with them.
* A simple way to add "below-triple-dash" comments would be cool. For
now, I guess we can do this by having the --- within the commit
message.
* The explanation on how to register one's email were unclear to me. It
told me that I had to register my email without telling how, and that
I had to send the series to myself before. Once I sent the series to
myself I got better explanation, hence reversing the order of the
advices would already be an improvement.
* The link to the original PR could be more visible. For now, I can get
to the PR by clicking the octocat icon, but perhaps a text "click here
to view the PR on GitHub" or a link on the whole title would have been
easier to find.
* I missed a way to specify In-reply-to: to follow up to my previous
version.
* The submitGit link on the top left does nothing for me. I would expect
to come back to the home page of submitGit.
* For completess: Junio just noticed in another thread that the patch
order is reversed, PATCH 2/2 predates PATCH 1/2 and the second is
In-Reply-To: the first.
* I was about to suggest that you post a comment on the GitHub pull
request when sending the email, but it is already the case, with a
link to Gmane. Very very cool.
* Did I mention how awesome the application is already? 'Cause it really
is!
Thanks a lot for doing this!
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-05-22 16:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 8:33 [Announce] submitGit for patch submission (was "Diffing submodule does not yield complete logs") Roberto Tyley
2015-05-22 9:42 ` Johannes Schindelin
2015-05-22 14:41 ` Johannes Schindelin
2015-05-22 17:14 ` Philip Oakley
2015-05-22 19:58 ` Johannes Schindelin
2015-05-22 21:35 ` Philip Oakley
2015-05-23 9:06 ` Johannes Schindelin
2015-05-22 13:06 ` Sebastian Schuberth
2015-05-22 13:25 ` Stefan Näwe
2015-05-22 14:17 ` Junio C Hamano
2015-05-22 17:40 ` Philip Oakley
2015-05-22 19:23 ` Stefan Beller
2015-05-22 19:59 ` Johannes Schindelin
2015-05-22 20:04 ` Junio C Hamano
2015-05-22 20:44 ` Stefan Beller
2015-05-23 9:11 ` Johannes Schindelin
2015-05-23 14:29 ` Matthieu Moy
[not found] ` <CAFY1edZ+5fW0FxQPO=qN6gqv8UfQUvjsutKvBOBj0CGbS8ms6A@mail.gmail.com>
2015-05-23 9:09 ` Johannes Schindelin
2015-05-22 16:14 ` Matthieu Moy [this message]
2015-05-22 16:27 ` Junio C Hamano
2015-05-22 16:53 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqd21slhdc.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Jens.Lehmann@web.de \
--cc=emma@gitforteams.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=johannes.schindelin@gmx.de \
--cc=rcdailey.lists@gmail.com \
--cc=roberto.tyley@gmail.com \
--cc=sbeller@google.com \
--cc=tfnico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).