git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>,
	"Roberto Tyley" <roberto.tyley@gmail.com>
Cc: "Stefan Beller" <sbeller@google.com>,
	"Robert Dailey" <rcdailey.lists@gmail.com>,
	"Heiko Voigt" <hvoigt@hvoigt.net>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>,
	"Jens Lehmann" <Jens.Lehmann@web.de>, "Git" <git@vger.kernel.org>,
	"Thomas Ferris Nicolaisen" <tfnico@gmail.com>,
	<emma@gitforteams.com>
Subject: Re: [Announce] submitGit for patch submission (was "Diffing submodule does not yield complete logs")
Date: Fri, 22 May 2015 18:40:36 +0100	[thread overview]
Message-ID: <64326DCF30A041379141BB51437E87A6@PhilipOakley> (raw)
In-Reply-To: xmqq8ucghf2s.fsf@gitster.dls.corp.google.com

From: "Junio C Hamano" <gitster@pobox.com>
> Roberto Tyley <roberto.tyley@gmail.com> writes:
>
>> Hello, I'm stepping up to do that work :) Or at least, I'm 
>> implementing a
>> one-way GitHub PR -> Mailing list tool, called submitGit:
>>
>> https://submitgit.herokuapp.com/
>
> Yay ;-)
>
>> Here's what a user does:
>>
>> * create a PR on https://github.com/git/git
>> * logs into https://submitgit.herokuapp.com/ with GitHub auth
>> * selects their PR on https://submitgit.herokuapp.com/git/git/pulls
>
> Reasonable.
>
>> * gets submitGit to email the PR as patches to themselves, in order 
>> to
>> check it looks ok
>
> I can see you are trying to be careful by doing this, but I am not
> sure if this step would actually help. Those who are not familiar
> with Git development are not expected to know what is "ok" in their
> original commit, and if they find bad formatting done by submitGit
> (e.g. adds their PR message before the three-dash line instead of
> after it), they cannot do much about it anyway.

I still think this is valuable for the spotting of the dumb mistakes we 
all make, and notice after the fact when we see the email in the hard 
light of day. There will still be poor commit messages and the like, but 
at least the raw content is more likely to be as the author desired.

>
>> * when they're ready, get submitGit to send it to the mailing list on
>> their behalf
>
> Nice.
>
>> All discussion of the patch *stays* on the mailing list
>
> Can you identify a reroll of an earlier submission?  If you can use
> the in-reply-to and make it a follow-up to the previous round, that
> would be great.
> --
Philip 

  reply	other threads:[~2015-05-22 17:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22  8:33 [Announce] submitGit for patch submission (was "Diffing submodule does not yield complete logs") Roberto Tyley
2015-05-22  9:42 ` Johannes Schindelin
2015-05-22 14:41   ` Johannes Schindelin
2015-05-22 17:14     ` Philip Oakley
2015-05-22 19:58       ` Johannes Schindelin
2015-05-22 21:35         ` Philip Oakley
2015-05-23  9:06           ` Johannes Schindelin
2015-05-22 13:06 ` Sebastian Schuberth
2015-05-22 13:25 ` Stefan Näwe
2015-05-22 14:17 ` Junio C Hamano
2015-05-22 17:40   ` Philip Oakley [this message]
2015-05-22 19:23     ` Stefan Beller
2015-05-22 19:59       ` Johannes Schindelin
2015-05-22 20:04         ` Junio C Hamano
2015-05-22 20:44           ` Stefan Beller
2015-05-23  9:11           ` Johannes Schindelin
2015-05-23 14:29       ` Matthieu Moy
     [not found]   ` <CAFY1edZ+5fW0FxQPO=qN6gqv8UfQUvjsutKvBOBj0CGbS8ms6A@mail.gmail.com>
2015-05-23  9:09     ` Johannes Schindelin
2015-05-22 16:14 ` Matthieu Moy
2015-05-22 16:27 ` Junio C Hamano
2015-05-22 16:53 ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64326DCF30A041379141BB51437E87A6@PhilipOakley \
    --to=philipoakley@iee.org \
    --cc=Jens.Lehmann@web.de \
    --cc=emma@gitforteams.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hvoigt@hvoigt.net \
    --cc=johannes.schindelin@gmx.de \
    --cc=rcdailey.lists@gmail.com \
    --cc=roberto.tyley@gmail.com \
    --cc=sbeller@google.com \
    --cc=tfnico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).