From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Siddharth Kannan <kannan.siddharth12@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, pranit.bauva@gmail.com,
peff@peff.net, pclouds@gmail.com,
sandals@crustytoothpaste.ath.cx
Subject: Re: [PATCH 0/4 v4] WIP: allow "-" as a shorthand for "previous branch"
Date: Thu, 16 Feb 2017 17:41:32 +0100 [thread overview]
Message-ID: <vpqa89mnl4z.fsf@anie.imag.fr> (raw)
In-Reply-To: <1487258054-32292-1-git-send-email-kannan.siddharth12@gmail.com> (Siddharth Kannan's message of "Thu, 16 Feb 2017 15:14:10 +0000")
Siddharth Kannan <kannan.siddharth12@gmail.com> writes:
> This is as per our discussion[1]. The patches and commit messages are based on
> Junio's patches that were posted as a reply to
> <20170212184132.12375-1-gitster@pobox.com>.
>
> As per Matthieu's comments, I have updated the tests, but there is still one
> thing that is not working: log -@{yesterday} or log -@{2.days.ago}
Note that I did not request that these things work, just that they seem
to be relevant tests: IMHO it's OK to reject them, but for example we
don't want them to segfault. And having a test is a good hint that you
thought about what could happen and to document it.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2017-02-16 16:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 15:14 [PATCH 0/4 v4] WIP: allow "-" as a shorthand for "previous branch" Siddharth Kannan
2017-02-16 15:14 ` [PATCH 1/4 v4] revision.c: do not update argv with unknown option Siddharth Kannan
2017-02-16 16:48 ` Matthieu Moy
2017-02-16 18:11 ` Junio C Hamano
2017-02-16 18:22 ` Matthieu Moy
2017-02-16 19:39 ` Siddharth Kannan
2017-02-16 15:14 ` [PATCH 2/4 v4] revision.c: swap if/else blocks Siddharth Kannan
2017-02-16 15:14 ` [PATCH 3/4 v4] revision.c: args starting with "-" might be a revision Siddharth Kannan
2017-02-16 15:14 ` [PATCH 4/4 v4] sha1_name.c: teach get_sha1_1 "-" shorthand for "@{-1}" Siddharth Kannan
2017-02-16 19:08 ` Junio C Hamano
2017-02-20 14:21 ` Siddharth Kannan
2017-02-20 20:30 ` Junio C Hamano
2017-02-22 6:27 ` Siddharth Kannan
2017-02-16 16:41 ` Matthieu Moy [this message]
2017-02-16 18:49 ` [PATCH 0/4 v4] WIP: allow "-" as a shorthand for "previous branch" Junio C Hamano
2017-02-16 19:43 ` Siddharth Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqa89mnl4z.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kannan.siddharth12@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=pranit.bauva@gmail.com \
--cc=sandals@crustytoothpaste.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).