From: Siddharth Kannan <kannan.siddharth12@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
Pranit Bauva <pranit.bauva@gmail.com>, Jeff King <peff@peff.net>,
pclouds@gmail.com,
"brian m. carlson" <sandals@crustytoothpaste.ath.cx>
Subject: Re: [PATCH 1/4 v4] revision.c: do not update argv with unknown option
Date: Fri, 17 Feb 2017 01:09:41 +0530 [thread overview]
Message-ID: <CAN-3QhrO2FDDNfXLZJm-3DO5fw6m0Ea0QjW4Cu+Ceo9aJJBPWg@mail.gmail.com> (raw)
In-Reply-To: <vpqwpcqgfmw.fsf@anie.imag.fr>
Hey Matthieu,
On 16 February 2017 at 23:52, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
>
> Indeed, I misread the patch. The explanation could be a little bit more
> "tired-reviewer-proof" by not using a past tone, perhaps
>
> 1. setup_revision, which is changed to ...
Oh, okay! Sorry about the confusion!
Yes, I used the past perfect tense to refer to changes that were made
in this particular patch!
I will change the message in the next version to something that's in
present tense.
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/
--
Best Regards,
- Siddharth.
next prev parent reply other threads:[~2017-02-16 19:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 15:14 [PATCH 0/4 v4] WIP: allow "-" as a shorthand for "previous branch" Siddharth Kannan
2017-02-16 15:14 ` [PATCH 1/4 v4] revision.c: do not update argv with unknown option Siddharth Kannan
2017-02-16 16:48 ` Matthieu Moy
2017-02-16 18:11 ` Junio C Hamano
2017-02-16 18:22 ` Matthieu Moy
2017-02-16 19:39 ` Siddharth Kannan [this message]
2017-02-16 15:14 ` [PATCH 2/4 v4] revision.c: swap if/else blocks Siddharth Kannan
2017-02-16 15:14 ` [PATCH 3/4 v4] revision.c: args starting with "-" might be a revision Siddharth Kannan
2017-02-16 15:14 ` [PATCH 4/4 v4] sha1_name.c: teach get_sha1_1 "-" shorthand for "@{-1}" Siddharth Kannan
2017-02-16 19:08 ` Junio C Hamano
2017-02-20 14:21 ` Siddharth Kannan
2017-02-20 20:30 ` Junio C Hamano
2017-02-22 6:27 ` Siddharth Kannan
2017-02-16 16:41 ` [PATCH 0/4 v4] WIP: allow "-" as a shorthand for "previous branch" Matthieu Moy
2017-02-16 18:49 ` Junio C Hamano
2017-02-16 19:43 ` Siddharth Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN-3QhrO2FDDNfXLZJm-3DO5fw6m0Ea0QjW4Cu+Ceo9aJJBPWg@mail.gmail.com \
--to=kannan.siddharth12@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=pranit.bauva@gmail.com \
--cc=sandals@crustytoothpaste.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).