From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] Suggest applicants to participate in review of other peoples' patches
Date: Sun, 08 Mar 2015 11:10:02 +0100 [thread overview]
Message-ID: <vpq61ab6br9.fsf@anie.imag.fr> (raw)
In-Reply-To: <xmqqd24lyejv.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Fri, 06 Mar 2015 13:57:40 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Jeff King <peff@peff.net> writes:
>
>> On Fri, Mar 06, 2015 at 12:53:57PM +0100, Matthieu Moy wrote:
>>
>>> Idea and most of the wording comes from Junio's message on the list. I
>>> added a hint to include links to review in the application (which makes
>>> the suggestion a bit stronger since it implies that it will be taken into
>>> account in the selection).
>>
>> Seems reasonable. I do not know what the quality of reviews will be from
>> applicants, but I guess we will find out. :)
>
> I actually was hoping to see an applicant replaying the review
> comments given to him to another applicant that makes the same kind
> of mistakes.
I'm also hoping that applicants just watch the mailing-list better, and
even if the don't actually write much, that they read a bit more what's
going on here.
I pushed my patch.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2015-03-08 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 7:44 GSoC applicants: discuss other applicants patches, perhaps? Junio C Hamano
2015-03-06 11:53 ` [PATCH] Suggest applicants to participate in review of other peoples' patches Matthieu Moy
2015-03-06 21:10 ` Jeff King
2015-03-06 21:57 ` Junio C Hamano
2015-03-08 10:10 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq61ab6br9.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).