git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: [PATCH] Suggest applicants to participate in review of other peoples' patches
Date: Fri,  6 Mar 2015 12:53:57 +0100	[thread overview]
Message-ID: <1425642837-31651-1-git-send-email-Matthieu.Moy@imag.fr> (raw)
In-Reply-To: <CAPc5daV7Dv8K8itmQhdf1CG-opMVw7DYyheHdcdL0r_9zFQR-Q@mail.gmail.com>

Idea and most of the wording comes from Junio's message on the list. I
added a hint to include links to review in the application (which makes
the suggestion a bit stronger since it implies that it will be taken into
account in the selection).

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
> What do mentors and others think?

Very good idea indeed.

 SoC-2015-Ideas.md | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/SoC-2015-Ideas.md b/SoC-2015-Ideas.md
index 0ccbcdc..ba8b25e 100644
--- a/SoC-2015-Ideas.md
+++ b/SoC-2015-Ideas.md
@@ -16,9 +16,22 @@ way for us to get experience with applicants, but it will also help
 applicants become familiar with Git's development and submission
 process.
 
+Also, working in Git project is not only about writing your own
+patches. Constructively critiquing design and implementation of
+patches by other people is also an important skill you need to learn
+in order to effectively collaborate with others. So, if you have time
+and inclination, it would be beneficial to read and understand other
+applicants' patches (or any other patch submitted to the mailing-list),
+think if you agree that the problem they are trying to solve is worth
+solving, the approach they are taking is the best way (or if you think
+of a better way to solve it), etc., and respond to their patches with
+the result of your thinking as a review.
+
 Please, include link(s) to the mailing-list discussion(s) related to
 your microproject in your application (e.g. linking to
-[gmane](http://news.gmane.org/gmane.comp.version-control.git)).
+[gmane](http://news.gmane.org/gmane.comp.version-control.git)). If you
+participate in the review of other patches, then you may also include
+links to discussions that would support your application.
 
 ## Note about the number of slots
 
-- 
2.3.0.157.g79e124b

  reply	other threads:[~2015-03-06 11:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06  7:44 GSoC applicants: discuss other applicants patches, perhaps? Junio C Hamano
2015-03-06 11:53 ` Matthieu Moy [this message]
2015-03-06 21:10   ` [PATCH] Suggest applicants to participate in review of other peoples' patches Jeff King
2015-03-06 21:57     ` Junio C Hamano
2015-03-08 10:10       ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425642837-31651-1-git-send-email-Matthieu.Moy@imag.fr \
    --to=matthieu.moy@imag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).