git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Matthias Andree" <matthias.andree@gmx.de>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "git.vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v3] To make GIT-VERSION-FILE, search for git more widely
Date: Sat, 09 May 2009 20:17:01 +0200	[thread overview]
Message-ID: <op.utoc2njr1e62zd@merlin.emma.line.org> (raw)
In-Reply-To: <7vskje6wsy.fsf@alter.siamese.dyndns.org>

Am 09.05.2009, 18:55 Uhr, schrieb Junio C Hamano <gitster@pobox.com>:

> "Matthias Andree" <matthias.andree@gmx.de> writes:
>
>>> Fine then.  Or you could just append "." to the $PATH ;-)
>>
>> "." in the super user's PATH? Cool stuff, and so innovative.
>
> I didn't mean to suggest PATH=$PATH:. *in the user's environment* ;-).
> You do that inside GIT-VERSION-FILE, which is essentially the same thing
> as running ./git$X from there.
>
> What's innovative is whoever is running build as root.

Back to the real problem, and that is re-checking GIT-VERSION-FILE as part
of "make install". I wonder if we should just have GIT-VERSION-GEN exit if
git isn't in $PATH, and at most copy version there -- rather than stomp
the DEF_VER somewhere.

-- 
Matthias Andree

  parent reply	other threads:[~2009-05-09 18:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07  9:22 [PATCH v3] To make GIT-VERSION-FILE, search for git more widely Matthias Andree
2009-05-07 11:49 ` Michael J Gruber
2009-05-07 12:04   ` Matthias Andree
2009-05-07 12:09     ` Michael J Gruber
2009-05-07 12:12       ` Matthias Andree
2009-05-08  0:05 ` Junio C Hamano
2009-05-08  8:27   ` Matthias Andree
2009-05-08  8:41     ` Junio C Hamano
2009-05-08 11:09       ` Matthias Andree
2009-05-09 16:55         ` Junio C Hamano
2009-05-09 17:10           ` Francis Galiegue
2009-05-09 18:17           ` Matthias Andree [this message]
2009-05-13 12:17           ` Matthias Andree
2009-05-13 19:32             ` Junio C Hamano
2009-06-02 10:55               ` Nanako Shiraishi
2009-06-02 15:50                 ` Junio C Hamano
2009-06-02 18:35                   ` Johannes Sixt
2009-06-03  7:32                     ` Matthias Andree
2009-06-04  0:12                     ` [PATCH v4] " Matthias Andree
2009-06-04  5:18                     ` [PATCH v3] " Junio C Hamano
2009-06-04  8:35                       ` Matthias Andree
2009-05-08  8:52     ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.utoc2njr1e62zd@merlin.emma.line.org \
    --to=matthias.andree@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).