From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Nanako Shiraishi <nanako3@lavabit.com>,
"Matthias Andree" <matthias.andree@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH v3] To make GIT-VERSION-FILE, search for git more widely
Date: Wed, 03 Jun 2009 22:18:53 -0700 [thread overview]
Message-ID: <7vvdnc37b6.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <200906022035.30081.j6t@kdbg.org> (Johannes Sixt's message of "Tue\, 2 Jun 2009 20\:35\:29 +0200")
Johannes Sixt <j6t@kdbg.org> writes:
> On Dienstag, 2. Juni 2009, Junio C Hamano wrote:
>> Nanako Shiraishi <nanako3@lavabit.com> writes:
>> > Junio, I think you forgot to take a follow-up action on this thread after
>> > sending this message. The patch favors the git program in the current
>> > directory.
>>
>> Indeed, I did, and I think I am Ok with the patch. Thanks for a
>> reminder.
>>
>> I thought there was an "simplicity" issue raised by J6t that was not
>> addressed, but after re-reading the thread I do not think it applies
>> (J6t?)
>
> Sorry, I don't recall anymore what I said; but since the thread petered out, I
> use this patch in the repository where I share Matthias' 'sudo make install'
> problem:
>
> Subject: [PATCH] version-gen: Use just built git if no other git is in PATH
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
>
> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
> index 39cde78..4779313 100755
> --- a/GIT-VERSION-GEN
> +++ b/GIT-VERSION-GEN
> @@ -3,6 +3,9 @@
> GVF=GIT-VERSION-FILE
> DEF_VER=v1.6.3.GIT
>
> +# use git that was just compiled if there is no git elsewhere in PATH
> +PATH=$PATH:.
> +
> LF='
> '
I actually think this is much saner and cleaner (it certainly is smaller),
especially having seen Matthias's v4, which feels a tad overengineered.
I honestly do not understand why we need to bend backwards to cater to
"sudo". Real men, when needing to do things as root, have always done
"su", and _if_ the environment is unsuited for the job, they can do:
$ su
# PATH=$PATH:/usr/local/bin make prefix=/usr/local install
next prev parent reply other threads:[~2009-06-04 5:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 9:22 [PATCH v3] To make GIT-VERSION-FILE, search for git more widely Matthias Andree
2009-05-07 11:49 ` Michael J Gruber
2009-05-07 12:04 ` Matthias Andree
2009-05-07 12:09 ` Michael J Gruber
2009-05-07 12:12 ` Matthias Andree
2009-05-08 0:05 ` Junio C Hamano
2009-05-08 8:27 ` Matthias Andree
2009-05-08 8:41 ` Junio C Hamano
2009-05-08 11:09 ` Matthias Andree
2009-05-09 16:55 ` Junio C Hamano
2009-05-09 17:10 ` Francis Galiegue
2009-05-09 18:17 ` Matthias Andree
2009-05-13 12:17 ` Matthias Andree
2009-05-13 19:32 ` Junio C Hamano
2009-06-02 10:55 ` Nanako Shiraishi
2009-06-02 15:50 ` Junio C Hamano
2009-06-02 18:35 ` Johannes Sixt
2009-06-03 7:32 ` Matthias Andree
2009-06-04 0:12 ` [PATCH v4] " Matthias Andree
2009-06-04 5:18 ` Junio C Hamano [this message]
2009-06-04 8:35 ` [PATCH v3] " Matthias Andree
2009-05-08 8:52 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdnc37b6.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=matthias.andree@gmx.de \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).