From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Tao Klerks via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff Hostetler" <git@jeffhostetler.com>,
"Tao Klerks" <tao@klerks.biz>, "Tao Klerks" <tao@klerks.biz>,
"Tao Klerks" <tao@klerks.biz>
Subject: Re: [PATCH v3 2/2] t7063: mtime-mangling instead of delays in untracked cache testing
Date: Wed, 9 Mar 2022 22:53:22 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2203092250080.357@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <dceb2857609fad8a8f93e489adc478ab0eb71c51.1646201124.git.gitgitgadget@gmail.com>
Hi Tao,
On Wed, 2 Mar 2022, Tao Klerks via GitGitGadget wrote:
> diff --git a/t/t7063-status-untracked-cache.sh b/t/t7063-status-untracked-cache.sh
> index a0c123b0a77..ca90ee805e7 100755
> --- a/t/t7063-status-untracked-cache.sh
> +++ b/t/t7063-status-untracked-cache.sh
> @@ -90,6 +90,9 @@ test_expect_success 'setup' '
> cd worktree &&
> mkdir done dtwo dthree &&
> touch one two three done/one dtwo/two dthree/three &&
> + test-tool chmtime =-300 one two three done/one dtwo/two dthree/three &&
> + test-tool chmtime =-300 done dtwo dthree &&
> + test-tool chmtime =-300 . &&
At first I puzzled why we need `done`, `dtwo`, dthree` and `.`, too, but
it makes sense: the invariant is that all of the files/directories whose
mtime is adjusted in these three new lines have the same mtime.
A similar issue is...
> @@ -520,14 +519,14 @@ test_expect_success 'create/modify files, some of which are gitignored' '
> echo three >done/three && # three is gitignored
> echo four >done/four && # four is gitignored at a higher level
> echo five >done/five && # five is not gitignored
> - echo test >base && #we need to ensure that the root dir is touched
> - rm base &&
> + test-tool chmtime =-180 done/two done/three done/four done/five done &&
> + # we need to ensure that the root dir is touched (in the past);
> + test-tool chmtime =-180 . &&
Here, where I needed a moment to understand the invariant (and hence the
need to adjust more than just the root directory's mtime).
> @@ -597,11 +595,11 @@ EOF
> test_expect_success 'set up for test of subdir and sparse checkouts' '
> mkdir done/sub &&
> mkdir done/sub/sub &&
> - echo "sub" > done/sub/sub/file
> + echo "sub" > done/sub/sub/file &&
> + test-tool chmtime =-120 done/sub/sub/file done/sub/sub done/sub done
Similar situation here, too.
All this is to say that this patch looks good to me.
Thanks,
Dscho
next prev parent reply other threads:[~2022-03-09 21:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 9:40 [PATCH 0/2] Reduce explicit sleep calls in t7063 untracked cache tests Tao Klerks via GitGitGadget
2022-02-28 9:40 ` [PATCH 1/2] t/helper/test-chmtime: update mingw to support chmtime on directories Tao Klerks via GitGitGadget
2022-02-28 15:27 ` Jeff Hostetler
2022-02-28 22:01 ` Junio C Hamano
2022-03-01 8:16 ` Tao Klerks
2022-02-28 22:00 ` Junio C Hamano
2022-03-01 8:21 ` Tao Klerks
2022-02-28 9:40 ` [PATCH 2/2] t7063: mtime-mangling instead of delays in untracked cache testing Tao Klerks via GitGitGadget
2022-02-28 22:19 ` Junio C Hamano
2022-03-01 9:44 ` Tao Klerks
2022-02-28 11:03 ` [PATCH 0/2] Reduce explicit sleep calls in t7063 untracked cache tests Ævar Arnfjörð Bjarmason
2022-02-28 15:29 ` Jeff Hostetler
2022-03-01 9:45 ` [PATCH v2 " Tao Klerks via GitGitGadget
2022-03-01 9:45 ` [PATCH v2 1/2] t/helper/test-chmtime: update mingw to support chmtime on directories Tao Klerks via GitGitGadget
2022-03-01 16:34 ` Jeff Hostetler
2022-03-01 21:14 ` Tao Klerks
2022-03-01 9:45 ` [PATCH v2 2/2] t7063: mtime-mangling instead of delays in untracked cache testing Tao Klerks via GitGitGadget
2022-03-01 18:03 ` Junio C Hamano
2022-03-01 22:13 ` Tao Klerks
2022-03-01 9:49 ` [PATCH v2 0/2] Reduce explicit sleep calls in t7063 untracked cache tests Tao Klerks
2022-03-01 17:49 ` Junio C Hamano
2022-03-02 6:05 ` [PATCH v3 " Tao Klerks via GitGitGadget
2022-03-02 6:05 ` [PATCH v3 1/2] t/helper/test-chmtime: update mingw to support chmtime on directories Tao Klerks via GitGitGadget
2022-03-09 21:46 ` Johannes Schindelin
2022-03-02 6:05 ` [PATCH v3 2/2] t7063: mtime-mangling instead of delays in untracked cache testing Tao Klerks via GitGitGadget
2022-03-09 21:53 ` Johannes Schindelin [this message]
2022-03-05 4:24 ` [PATCH v3 0/2] Reduce explicit sleep calls in t7063 untracked cache tests Tao Klerks
2022-03-06 21:57 ` Junio C Hamano
2022-03-07 5:37 ` Tao Klerks
2022-03-07 18:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2203092250080.357@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=tao@klerks.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).