From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Slavica Đukić" <slawica92@hotmail.com>,
"Denton Liu" <liu.denton@gmail.com>
Subject: Re: [PATCH 0/2] Use the built-in implementation of the interactive add command by default
Date: Mon, 6 Dec 2021 16:59:26 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2112061659010.27797@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <2ffbab1a-d5b2-fee5-806b-4e81eb759e11@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]
Hi Philippe,
On Fri, 3 Dec 2021, Philippe Blain wrote:
> Le 2021-11-30 à 09:14, Johannes Schindelin via GitGitGadget a écrit :
> > Over two years ago, Slavica Đukić participated in the Outreachy project,
> > starting to implement a built-in version of the interactive git add command.
> > A little over a year ago, Git turned on that mode whenever users were
> > running with feature.experimental = true.
> >
> > It is time to declare this implementation robust, to use it by default, and
> > to start deprecating the scripted implementation.
> >
> > Johannes Schindelin (2):
> > t2016: require the PERL prereq only when necessary
> > add -i: default to the built-in implementation
> >
> > Documentation/config/add.txt | 6 +++---
> > builtin/add.c | 15 +++++--------
> > ci/run-build-and-tests.sh | 2 +-
> > t/README | 2 +-
> > t/t2016-checkout-patch.sh | 42 +++++++++++++++++++-----------------
> > 5 files changed, 32 insertions(+), 35 deletions(-)
>
> I just noticed that 'INSTALL' mentions that Perl is needed for 'git add
> interactive'
> et al, so maybe we would want to tweak the wording a bit in there when switch
> the default
> to the C version ?
Not yet. Only once we remove `git-add--interactive.perl`.
Thanks,
Dscho
prev parent reply other threads:[~2021-12-06 16:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 14:14 [PATCH 0/2] Use the built-in implementation of the interactive add command by default Johannes Schindelin via GitGitGadget
2021-11-30 14:14 ` [PATCH 1/2] t2016: require the PERL prereq only when necessary Johannes Schindelin via GitGitGadget
2021-12-01 22:25 ` Junio C Hamano
2021-12-02 14:57 ` Johannes Schindelin
2021-11-30 14:14 ` [PATCH 2/2] add -i: default to the built-in implementation Johannes Schindelin via GitGitGadget
2021-12-01 11:20 ` Phillip Wood
2021-12-02 15:01 ` Johannes Schindelin
2021-12-02 16:58 ` Junio C Hamano
2021-12-02 17:43 ` Ramsay Jones
2021-12-10 22:59 ` Johannes Schindelin
2021-12-01 13:37 ` Ævar Arnfjörð Bjarmason
2021-12-01 22:41 ` Junio C Hamano
2021-12-01 22:34 ` Junio C Hamano
2021-12-02 17:30 ` Johannes Schindelin
2021-12-09 4:12 ` [PATCH] fixup! " Junio C Hamano
2021-12-10 22:55 ` Johannes Schindelin
2021-11-30 20:56 ` [PATCH 0/2] Use the built-in implementation of the interactive add command by default Jeff King
2021-11-30 21:15 ` Junio C Hamano
2021-12-01 13:43 ` Ævar Arnfjörð Bjarmason
2021-12-01 21:24 ` Carlo Arenas
2021-12-02 17:33 ` Johannes Schindelin
2021-12-03 13:58 ` Philippe Blain
2021-12-06 15:59 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2112061659010.27797@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=liu.denton@gmail.com \
--cc=slawica92@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).