git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Dennis Ameling <dennis@dennisameling.com>
Subject: Re: [PATCH] ci(vs-build): stop passing the iconv library location explicitly
Date: Fri, 4 Dec 2020 23:12:57 +0100 (CET)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.2012041612300.25979@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqv9dhe3wi.fsf@gitster.c.googlers.com>

Hi Junio,

On Fri, 4 Dec 2020, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Dennis Ameling <dennis@dennisameling.com>
> >
> > Something changed in `vcpkg` (which we use in our Visual C++ build to
> > provide the dependencies such as libcurl) and our `vs-build` job started
> > failing in CI. The reason is that we had a work-around in place to help
> > CMake find iconv, and this work-around is neither needed nor does it
> > work anymore.
> >
> > For the full discussion with the vcpkg project, see this comment:
> > https://github.com/microsoft/vcpkg/issues/14780#issuecomment-735368280
> >
> > Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >     ci: fix the vs-build job so that CI builds pass again
> >
> >     This was noticed first in a Git for Windows PR.
>
> This is probably the same breakage I've been seeing, e.g.
> https://github.com/git/git/runs/1494253517

Yes.

> I guess we should just apply directly to 'master' (or 'maint' and
> merge up), but I can queue it just like all other topics and have it
> traverse through 'seen'->'next'->'master'.

Whatever is easier for you.

Thanks,
Dscho

      reply	other threads:[~2020-12-04 22:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 14:22 [PATCH] ci(vs-build): stop passing the iconv library location explicitly Johannes Schindelin via GitGitGadget
2020-12-04 20:02 ` Junio C Hamano
2020-12-04 22:12   ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.2012041612300.25979@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=dennis@dennisameling.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).