From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id CC29A1FB0A for ; Fri, 4 Dec 2020 22:17:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726430AbgLDWPD (ORCPT ); Fri, 4 Dec 2020 17:15:03 -0500 Received: from mout.gmx.net ([212.227.17.20]:39991 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgLDWPD (ORCPT ); Fri, 4 Dec 2020 17:15:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607119980; bh=SELL+VJ4C+8lb3iNbvcuhOGjA7tmasWTx06M7xzDUf0=; h=X-UI-Sender-Class:Date:From:To:cc:Subject:In-Reply-To:References; b=F8E/Cjmi0zY11aAyo5fm3/FRpWqAxmrHWqvY2YDNMM9OTLWwEmvrIiVC1UiFB+ci+ 86erOijCxx/8FWEvowJm5Vk4RpapbVWYLgFjUt5xEihqPvIsX8jvWLSXMv4Mu0MSmY 3169PjXb9BDOr3lQFF9NdNsdVpCG/FY3LlOGTo34= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [172.28.88.62] ([89.1.212.111]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4hvb-1k42Bv1CmV-011i6w; Fri, 04 Dec 2020 23:13:00 +0100 Date: Fri, 4 Dec 2020 23:12:57 +0100 (CET) From: Johannes Schindelin X-X-Sender: virtualbox@gitforwindows.org To: Junio C Hamano cc: Johannes Schindelin via GitGitGadget , git@vger.kernel.org, Dennis Ameling Subject: Re: [PATCH] ci(vs-build): stop passing the iconv library location explicitly In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21.1 (DEB 209 2017-03-23) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Provags-ID: V03:K1:VpHtvDjaiUF6yUa26YjPxydvgYW66sxTGmOUl21i/leTeFlZjNw ziG43d3eXX7533KP8uwTtu/B2JcOplt+6+y/tFMG/WqwlUVuXR5luP3qyXJV5SGHP0Rrs8j 2PHIKq3l4VYKCHu5mBcu5nFZeY9CInvB/LQfSI1y8Q4a0hhwD2aNlck1DRxO/VQ+n9ME+DW h6cYfokKCAD8IfekTpSBw== X-UI-Out-Filterresults: notjunk:1;V03:K0:r45dm4U3QeI=:VsfLwDH5GfwtCOcITL9T4t AdczpSBDoGwAfEqLdoXZIGt57h83EVNgMTeFWldWffxPsSoYqLXEZ6+p/e7JfjIyS/uPXmvY9 /jkLIBh57VLepuxEaAsl51axNmdDueY6hgyD+Z8QFYo1h+e9iQR+VQriUn5zXjLOV1ocfCrFE jQn0B6IWEejFe4PLvwq2CItziZ/GK/Xb6/08R6wuQl+qoBAGWPJGHl1+TcCOIjjhrJ6xfo5mZ V5Qh9LIBYnmrItv8MRaKxcI2KMYZudfkfqlmdmmSSTG+Aj5V8dgGx13vVbuTf6okdwUV45+e0 ytXxpu26tQb8KbsXeHO83aCC9LubrYe2ENeoV3tso1tSofQkWefRcMg9X7+E7RWir6pgcotp/ 4KNSSAC7obfI6WandkAQ0lJ/DJa25abdTP654sVirUhRqJgCchjmXZyM1Z+/tkzh3JWpkaK95 F6U81Sou/4Ri2S7rUI9BFf8i8zbW1BMY/kXYVLW5qvzYzOtkwiOsMh+S3uR0ZNlLCpIWohyfr NhDs8QT7ZQ47cbs8SdCL7O60onocibjyyveOqeSmtDEDqlR6iSTjb2/JMxvzGNjmIM+iSmBvY PJDeodEBoEyJN2PtGCaTuj6MUQ2Lk0nkuAlKjQRBTgD4G+3VeANvuwAu2zFq3GTd8V+Fh7MuK jHwSYOhYPH+3r38IQ+DZ6MibBSkuqFoB6CK2A9o7IX6xMTcdLhkkiDRUJaYgAF66YtIjusP1R 6wW4e4qzgw53Ji82rPKVfPXC1Fp0U8CXH5gVTMaw1bsUslLSgr120LHecGop6WpqIteZbvrH8 ltBjlsQ1Dpqnlw9D0PPJnH6JeimqbmYSHbOkr4k6zVNa9E0rX3j4KGGw3iTR1AIf2HNLdzT3s OEGHbWek7OMdbneUgd/d+fa/BRBLqw/BOQQNIpZNQ= Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Junio, On Fri, 4 Dec 2020, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Dennis Ameling > > > > Something changed in `vcpkg` (which we use in our Visual C++ build to > > provide the dependencies such as libcurl) and our `vs-build` job start= ed > > failing in CI. The reason is that we had a work-around in place to hel= p > > CMake find iconv, and this work-around is neither needed nor does it > > work anymore. > > > > For the full discussion with the vcpkg project, see this comment: > > https://github.com/microsoft/vcpkg/issues/14780#issuecomment-735368280 > > > > Signed-off-by: Dennis Ameling > > Signed-off-by: Johannes Schindelin > > --- > > ci: fix the vs-build job so that CI builds pass again > > > > This was noticed first in a Git for Windows PR. > > This is probably the same breakage I've been seeing, e.g. > https://github.com/git/git/runs/1494253517 Yes. > I guess we should just apply directly to 'master' (or 'maint' and > merge up), but I can queue it just like all other topics and have it > traverse through 'seen'->'next'->'master'. Whatever is easier for you. Thanks, Dscho