git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Chris. Webster" <chris@webstech.net>
Subject: Re: [PATCH] ci: avoid using the deprecated `set-env` construct
Date: Wed, 18 Nov 2020 12:48:53 +0100 (CET)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.2011181248320.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqq8saz68ro.fsf@gitster.c.googlers.com>

Hi Junio,

On Tue, 17 Nov 2020, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> Perhaps like the following (which is copied-and-pasted without
> >> understanding what is going on or without doing nothing more than
> >> skimming [*1*])?
> >
> > Yes, of course, this precisely what we need.
>
> Thanks.
>
> --- >8 ------ >8 ------ >8 --- cut here --- >8 ------ >8 ------ >8 ---
>
> Subject: [PATCH] ci: avoid `set-env` construct in print-test-failures.sh
>
> Imitating cac42e47 (ci: avoid using the deprecated `set-env`
> construct, 2020-11-07), avoid deprecated ::set-env and use the
> recommended alternative instead in print-test-failures.sh
>
> Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Thank you so much for tying up this loose end,
Dscho

> ---
>  ci/print-test-failures.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ci/print-test-failures.sh b/ci/print-test-failures.sh
> index 92a983a265..c70d6cdbf2 100755
> --- a/ci/print-test-failures.sh
> +++ b/ci/print-test-failures.sh
> @@ -48,7 +48,7 @@ do
>  			;;
>  		github-actions)
>  			mkdir -p failed-test-artifacts
> -			echo "::set-env name=FAILED_TEST_ARTIFACTS::t/failed-test-artifacts"
> +			echo "FAILED_TEST_ARTIFACTS=t/failed-test-artifacts" >>$GITHUB_ENV
>  			cp "${TEST_EXIT%.exit}.out" failed-test-artifacts/
>  			tar czf failed-test-artifacts/"$test_name".trash.tar.gz "$trash_dir"
>  			continue
> --
> 2.29.2-458-g8cf0a80384
>
>

      reply	other threads:[~2020-11-18 11:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-07  1:21 Johannes Schindelin via GitGitGadget
2020-11-07  6:51 ` Chris Webster
2020-11-17  6:19 ` Junio C Hamano
2020-11-17 15:21   ` Johannes Schindelin
2020-11-17 20:14     ` Junio C Hamano
2020-11-18 11:48       ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.2011181248320.56@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=chris@webstech.net \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).