From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Chris. Webster" <chris@webstech.net>
Subject: Re: [PATCH] ci: avoid using the deprecated `set-env` construct
Date: Tue, 17 Nov 2020 16:21:33 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2011171620180.18437@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqq8sb07bfa.fsf@gitster.c.googlers.com>
Hi Junio,
On Mon, 16 Nov 2020, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > The `set-env` construct was deprecated as of the announcement in
> > https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
> > ...
> > diff --git a/.github/workflows/check-whitespace.yml b/.github/workflows/check-whitespace.yml
> > index 9d070b9cdf..c74b47de9e 100644
> > --- a/.github/workflows/check-whitespace.yml
> > +++ b/.github/workflows/check-whitespace.yml
> > @@ -14,7 +14,7 @@ jobs:
> > steps:
> > - name: Set commit count
> > shell: bash
> > - run: echo "::set-env name=COMMIT_DEPTH::$((1+$COMMITS))"
> > + run: echo "COMMIT_DEPTH=$((1+$COMMITS))" >>$GITHUB_ENV
> > env:
> > COMMITS: ${{ github.event.pull_request.commits }}
>
> Do we need something similar for ci/print-test-failures.sh to
> prevent failures like https://github.com/git/git/runs/1409815807?
>
> Perhaps like the following (which is copied-and-pasted without
> understanding what is going on or without doing nothing more than
> skimming [*1*])?
Yes, of course, this precisely what we need.
Sorry for not even _thinking_ about `git grep set-env`. This seems the
only remaining use of that construct in our workflows, though.
Thanks,
Dscho
>
>
> Reference
>
> *1* https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
>
>
> ci/print-test-failures.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git c/ci/print-test-failures.sh w/ci/print-test-failures.sh
> index 92a983a265..c70d6cdbf2 100755
> --- c/ci/print-test-failures.sh
> +++ w/ci/print-test-failures.sh
> @@ -48,7 +48,7 @@ do
> ;;
> github-actions)
> mkdir -p failed-test-artifacts
> - echo "::set-env name=FAILED_TEST_ARTIFACTS::t/failed-test-artifacts"
> + echo "FAILED_TEST_ARTIFACTS=t/failed-test-artifacts" >>$GITHUB_ENV
> cp "${TEST_EXIT%.exit}.out" failed-test-artifacts/
> tar czf failed-test-artifacts/"$test_name".trash.tar.gz "$trash_dir"
> continue
>
>
next prev parent reply other threads:[~2020-11-17 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 1:21 [PATCH] ci: avoid using the deprecated `set-env` construct Johannes Schindelin via GitGitGadget
2020-11-07 6:51 ` Chris Webster
2020-11-17 6:19 ` Junio C Hamano
2020-11-17 15:21 ` Johannes Schindelin [this message]
2020-11-17 20:14 ` Junio C Hamano
2020-11-18 11:48 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2011171620180.18437@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=chris@webstech.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).