From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC PATCH] Makefile: create externcheck target
Date: Thu, 8 Oct 2020 11:32:03 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2010081125390.50@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <1c2ee1c40ccde18a008262aeaf23a17da2064eae.1602142232.git.liu.denton@gmail.com>
Hi Denton,
On Thu, 8 Oct 2020, Denton Liu wrote:
> In b199d7147a (*.[ch]: remove extern from function declarations using
> sed, 2019-04-29), we used sed to remove extern from function
> definitions. In order to help find and remove future instances of this,
> teach Makefile the `externcheck` target which runs the sed script
> included in that commit on all applicable source files.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
>
> Notes:
> I run this target periodically to ensure that no new instances of extern
> function definitions are introduced. Is this something that we want to
> consider adding for real?
Sure, and then hook it up in `ci/run-static-analysis.sh`.
But maybe add it _after_ coccicheck-pending, and add it to the `.PHONY`
line that's just outside of this patch's context lines?
Ciao,
Dscho
P.S.: I am not really certain that the `\s` is portable, I do not see any
mention of it in
https://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap09.html#tag_09_03
and would therefore expect BSD sed not to handle this correctly. In any
case, the `-i` is _not_ portable, as BSD sed takes a mandatory argument
(see
https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux
for more details).
>
> Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 5311b1d2c4..791faa24cf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2885,6 +2885,9 @@ COCCI_SOURCES = $(filter-out $(THIRD_PARTY_SOURCES),$(FOUND_C_SOURCES))
> fi
> coccicheck: $(addsuffix .patch,$(filter-out %.pending.cocci,$(wildcard contrib/coccinelle/*.cocci)))
>
> +externcheck: $(filter-out $(THIRD_PARTY_SOURCES),$(filter %.c %.h,$(shell $(FIND_SOURCE_FILES))))
> + sed -i 's/^\(\s*\)extern \([^(]*([^*]\)/\1\2/' $^
> +
> # See contrib/coccinelle/README
> coccicheck-pending: $(addsuffix .patch,$(wildcard contrib/coccinelle/*.pending.cocci))
>
> --
> 2.29.0.rc0.261.g7178c9af9c
>
>
next prev parent reply other threads:[~2020-10-08 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 8:31 [PATCH] compat/mingw.h: drop extern from function declaration Denton Liu
2020-10-07 6:44 ` Johannes Schindelin
2020-10-08 7:30 ` [RFC PATCH] Makefile: create externcheck target Denton Liu
2020-10-08 9:32 ` Johannes Schindelin [this message]
2020-10-08 9:52 ` Denton Liu
2020-10-08 14:26 ` Johannes Schindelin
2020-10-09 2:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2010081125390.50@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).