From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] compat/mingw.h: drop extern from function declaration
Date: Wed, 7 Oct 2020 08:44:45 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2010070844340.50@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <9e5a8625cab217bd6aaba68da081bc801354b903.1602059508.git.liu.denton@gmail.com>
Hi Denton,
On Wed, 7 Oct 2020, Denton Liu wrote:
> In 554544276a (*.[ch]: remove extern from function declarations using
> spatch, 2019-04-29), `extern` on function declarations were declared to
> be redundant and thus removed from the codebase. An `extern` was
> accidentally reintroduced in 08809c09aa (mingw: add a helper function to
> attach GDB to the current process, 2020-02-13).
>
> Remove this spurious `extern`.
ACK!
Thanks,
Dscho
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
>
> Notes:
> This patch is based on 554544276a, formerly 'js/mingw-open-in-gdb'.
>
> compat/mingw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/mingw.h b/compat/mingw.h
> index 88c07c4520..5c34547539 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -599,7 +599,7 @@ int main(int argc, const char **argv);
> * Call this function to open a new MinTTY (this assumes you are in Git for
> * Windows' SDK) with a GDB that attaches to the current process right away.
> */
> -extern void open_in_gdb(void);
> +void open_in_gdb(void);
>
> /*
> * Used by Pthread API implementation for Windows
> --
> 2.28.0.942.g77c4c6094c
>
>
next prev parent reply other threads:[~2020-10-07 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 8:31 [PATCH] compat/mingw.h: drop extern from function declaration Denton Liu
2020-10-07 6:44 ` Johannes Schindelin [this message]
2020-10-08 7:30 ` [RFC PATCH] Makefile: create externcheck target Denton Liu
2020-10-08 9:32 ` Johannes Schindelin
2020-10-08 9:52 ` Denton Liu
2020-10-08 14:26 ` Johannes Schindelin
2020-10-09 2:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2010070844340.50@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).