From: Johannes Schindelin <Johannes.Schindelin@gmx.de> To: Jeff King <firstname.lastname@example.org> Cc: email@example.com, Tom Hale <firstname.lastname@example.org> Subject: Re: [PATCH 2/2] add--interactive.perl: specify --no-color explicitly Date: Tue, 8 Sep 2020 20:51:31 +0200 (CEST) [thread overview] Message-ID: <nycvar.QRO.email@example.com> (raw) In-Reply-To: <20200907081739.GB1263923@coredump.intra.peff.net> Hi Peff, ACK on both patches, just one clarification: On Mon, 7 Sep 2020, Jeff King wrote: > [...] > > One could argue that the test isn't very realistic; it's setting up this > "pretend there's a pager" situation to get around the tty restrictions > of the test environment. So one option would be to move back towards > using a real tty. [...] The main reason why we moved away from the "real" TTY is that the TTY we simulate in `t/test-terminal.perl` is not actually real at all on Windows. Instead, it is the Cygwin/MSYS2-emulated version of a PTY, and as a consequence `git.exe` simply has no way of accessing it. Which means that by moving "back towards using a real tty" we would lose all test coverage on Windows, which is not a thought I like to entertain. Ciao, Dscho
next prev parent reply other threads:[~2020-09-08 18:52 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-07 8:06 [PATCH 0/2] some minor add--interactive fixes Jeff King 2020-09-07 8:08 ` [PATCH 1/2] add-patch: fix inverted return code of repo_read_index() Jeff King 2020-09-07 8:17 ` [PATCH 2/2] add--interactive.perl: specify --no-color explicitly Jeff King 2020-09-07 8:25 ` Jeff King 2020-09-08 16:25 ` Junio C Hamano 2020-09-08 18:51 ` Johannes Schindelin [this message] 2020-09-09 9:15 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=nycvar.QRO.firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/2] add--interactive.perl: specify --no-color explicitly' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).