From: Junio C Hamano <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: firstname.lastname@example.org, Tom Hale <email@example.com>, Johannes Schindelin <Johannes.Schindelin@gmx.de> Subject: Re: [PATCH 2/2] add--interactive.perl: specify --no-color explicitly Date: Tue, 08 Sep 2020 09:25:31 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20200907082510.GA1264377@coredump.intra.peff.net> (Jeff King's message of "Mon, 7 Sep 2020 04:25:10 -0400") Jeff King <email@example.com> writes: > By the way, this is an instance of a more generic bug, which is that: > > git -p my-script > > will cause any sub-programs of git-my-script to think their stdout is > going to a pager, even if my-script redirects them to a file or another > pipe. > > I had a solution long ago in: > > https://lore.kernel.org/git/20150810052353.GB15441@sigill.intra.peff.net/ > > but it raises a bunch of interesting portability questions. Since this > comes up so rarely, I never really pursued it further. That indeed is from long ago ;-) and I still kind of like it. Is the issue that some platforms do not even have inum of the "thing" connected to a file descriptor? I think a fallback code for such a system can just return a constant pipe ID to anybody asks, so that an exported GIT_PAGER_PIPE_ID would always match, which gives the behaviour identical to what we currently do with GIT_PAGER_IN_USE, and that would be one way to help those capable of giving useful IDs while not harming others. Thanks.
next prev parent reply other threads:[~2020-09-08 16:55 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-07 8:06 [PATCH 0/2] some minor add--interactive fixes Jeff King 2020-09-07 8:08 ` [PATCH 1/2] add-patch: fix inverted return code of repo_read_index() Jeff King 2020-09-07 8:17 ` [PATCH 2/2] add--interactive.perl: specify --no-color explicitly Jeff King 2020-09-07 8:25 ` Jeff King 2020-09-08 16:25 ` Junio C Hamano [this message] 2020-09-08 18:51 ` Johannes Schindelin 2020-09-09 9:15 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Johannes.Schindelin@gmx.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/2] add--interactive.perl: specify --no-color explicitly' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).