From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] ci: run `hdr-check` as part of the `Static Analysis` job
Date: Tue, 1 Oct 2019 20:45:24 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1910012041550.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20191001164258.GA1356@generichostname>
Hi Denton,
On Tue, 1 Oct 2019, Denton Liu wrote:
> Sorry for not replying or rolling this in earlier, I was waiting for
> my series to hit master before doing this change but I guess it
> doesn't really hurt to do it any earlier.
No worries, thank you for working on this!
I wonder whether it would make sense to add a `hdr-check` to at least
one macOS and on Windows job, too, so that we get some confidence in the
non-Linux contributions. But that I _will_ leave to others ;-)
> On Tue, Oct 01, 2019 at 04:16:26AM -0700, Johannes Schindelin via GitGitGadget wrote:
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > azure-pipelines.yml | 2 +-
> > ci/install-dependencies.sh | 3 ++-
> > ci/run-static-analysis.sh | 3 +++
> > 3 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/azure-pipelines.yml b/azure-pipelines.yml
> > index c329b7218b..15831f6006 100644
> > --- a/azure-pipelines.yml
> > +++ b/azure-pipelines.yml
> > @@ -354,7 +354,7 @@ jobs:
> > test "$GITFILESHAREPWD" = '$(gitfileshare.pwd)' || ci/mount-fileshare.sh //gitfileshare.file.core.windows.net/test-cache gitfileshare "$GITFILESHAREPWD" "$HOME/test-cache" || exit 1
> >
> > sudo apt-get update &&
> > - sudo apt-get install -y coccinelle &&
> > + sudo apt-get install -y coccinelle coccinelle libcurl4-openssl-dev libssl-dev libexpat-dev gettext &&
>
> Seems like you accidentally included coccinelle twice.
Good point (copy-edit fail!). I force-pushed a fixed version, and will
probably send out a new version tomorrow or Friday.
Thanks,
Dscho
>
> Anyway, thanks for picking up where I left off.
>
> -Denton
>
> >
> > export jobname=StaticAnalysis &&
> >
> > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> > index 8cc72503cb..8ce9ce276e 100755
> > --- a/ci/install-dependencies.sh
> > +++ b/ci/install-dependencies.sh
> > @@ -49,7 +49,8 @@ osx-clang|osx-gcc)
> > ;;
> > StaticAnalysis)
> > sudo apt-get -q update
> > - sudo apt-get -q -y install coccinelle
> > + sudo apt-get -q -y install coccinelle libcurl4-openssl-dev libssl-dev \
> > + libexpat-dev gettext
> > ;;
> > Documentation)
> > sudo apt-get -q update
> > diff --git a/ci/run-static-analysis.sh b/ci/run-static-analysis.sh
> > index a19aa7ebbc..65bcebda41 100755
> > --- a/ci/run-static-analysis.sh
> > +++ b/ci/run-static-analysis.sh
> > @@ -26,4 +26,7 @@ then
> > exit 1
> > fi
> >
> > +make hdr-check ||
> > +exit 1
> > +
> > save_good_tree
> > --
> > gitgitgadget
>
next prev parent reply other threads:[~2019-10-01 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 11:16 [PATCH 0/1] Include hdr-check in the CI builds Johannes Schindelin via GitGitGadget
2019-10-01 11:16 ` [PATCH 1/1] ci: run `hdr-check` as part of the `Static Analysis` job Johannes Schindelin via GitGitGadget
2019-10-01 16:42 ` Denton Liu
2019-10-01 18:45 ` Johannes Schindelin [this message]
2019-10-02 6:11 ` Junio C Hamano
2019-10-02 9:17 ` Johannes Schindelin
2019-10-07 18:51 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1910012041550.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).