From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/1] ci: run `hdr-check` as part of the `Static Analysis` job
Date: Wed, 2 Oct 2019 11:17:03 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1910021116400.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqq7e5nfzgx.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Wed, 2 Oct 2019, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > - sudo apt-get install -y coccinelle &&
> > + sudo apt-get install -y coccinelle coccinelle libcurl4-openssl-dev libssl-dev libexpat-dev gettext &&
>
> I think "s/coccinelle //" is necessary here (assuming that "apt-get install"
> is the same Debian thing I know about).
>
> Will do so locally, so no need to resend, but "Yeah, that was a
> typo" or "no stupid, what I wrote is right" would be a nice
> response to see, especially if I have to undo the local fix.
Yes, this was a copy-edit fail on my part.
Thanks,
Dscho
>
> Thanks.
>
>
> > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> > index 8cc72503cb..8ce9ce276e 100755
> > --- a/ci/install-dependencies.sh
> > +++ b/ci/install-dependencies.sh
> > @@ -49,7 +49,8 @@ osx-clang|osx-gcc)
> > ;;
> > StaticAnalysis)
> > sudo apt-get -q update
> > - sudo apt-get -q -y install coccinelle
> > + sudo apt-get -q -y install coccinelle libcurl4-openssl-dev libssl-dev \
> > + libexpat-dev gettext
> > ;;
> > Documentation)
> > sudo apt-get -q update
> > diff --git a/ci/run-static-analysis.sh b/ci/run-static-analysis.sh
> > index a19aa7ebbc..65bcebda41 100755
> > --- a/ci/run-static-analysis.sh
> > +++ b/ci/run-static-analysis.sh
> > @@ -26,4 +26,7 @@ then
> > exit 1
> > fi
> >
> > +make hdr-check ||
> > +exit 1
> > +
> > save_good_tree
>
next prev parent reply other threads:[~2019-10-02 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 11:16 [PATCH 0/1] Include hdr-check in the CI builds Johannes Schindelin via GitGitGadget
2019-10-01 11:16 ` [PATCH 1/1] ci: run `hdr-check` as part of the `Static Analysis` job Johannes Schindelin via GitGitGadget
2019-10-01 16:42 ` Denton Liu
2019-10-01 18:45 ` Johannes Schindelin
2019-10-02 6:11 ` Junio C Hamano
2019-10-02 9:17 ` Johannes Schindelin [this message]
2019-10-07 18:51 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1910021116400.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).