From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Phillip Wood <phillip.wood@talktalk.net>
Subject: Re: [PATCH v3 0/2] rebase -i: introduce the 'break' command
Date: Fri, 12 Oct 2018 17:32:35 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1810121732240.561@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqva679sc8.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Fri, 12 Oct 2018, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > This patch introduces that, based on ag/rebase-i-in-c.
> >
> > Changes since v2:
> >
> > * Fixed two typos.
> > * When interrupting the rebase, break now outputs a message.
>
> I was about to merge the whole collection of topics to 'next', but
> this came to stop me just in time.
>
> The typofixes are appreciated of course, and look trivially correct.
>
> I find that the if() condition that does too many side-effect-full
> operations in stopped-at-head shows bad taste. It is still short
> enough to understand what each step is trying to do, but would
> encourage others who later may touch the code to make it even more
> complex.
>
> But it is a short and isolated static helper function, so I won't
> complain too loudly.
>
> Will replace and requeue.
Thanks,
Dscho
>
> Thanks.
>
next prev parent reply other threads:[~2018-10-12 15:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 15:00 [PATCH 0/1] rebase -i: introduce the 'break' command Johannes Schindelin via GitGitGadget
2018-10-03 15:00 ` [PATCH 1/1] " Johannes Schindelin via GitGitGadget
2018-10-05 8:15 ` Junio C Hamano
2018-10-05 8:36 ` Jacob Keller
2018-10-05 15:36 ` Johannes Schindelin
2018-10-09 3:59 ` Junio C Hamano
2018-10-09 5:27 ` Junio C Hamano
2018-10-10 8:53 ` [PATCH v2 0/2] " Johannes Schindelin via GitGitGadget
2018-10-10 8:53 ` [PATCH v2 1/2] rebase -i: clarify what happens on a failed `exec` Johannes Schindelin via GitGitGadget
2018-10-10 9:46 ` Eric Sunshine
2018-10-11 8:15 ` Junio C Hamano
2018-10-12 8:36 ` Johannes Schindelin
2018-10-10 8:53 ` [PATCH v2 2/2] rebase -i: introduce the 'break' command Johannes Schindelin via GitGitGadget
2018-10-11 9:08 ` Phillip Wood
2018-10-12 8:35 ` Johannes Schindelin
2018-10-12 11:09 ` Phillip Wood
2018-10-12 11:24 ` Johannes Schindelin
2018-10-12 13:14 ` [PATCH v3 0/2] " Johannes Schindelin via GitGitGadget
2018-10-12 13:14 ` [PATCH v3 1/2] rebase -i: clarify what happens on a failed `exec` Johannes Schindelin via GitGitGadget
2018-10-12 13:14 ` [PATCH v3 2/2] rebase -i: introduce the 'break' command Johannes Schindelin via GitGitGadget
2018-10-12 14:09 ` Junio C Hamano
2018-10-12 15:31 ` Johannes Schindelin
2018-10-12 14:01 ` [PATCH v3 0/2] " Junio C Hamano
2018-10-12 15:32 ` Johannes Schindelin [this message]
2018-10-25 20:47 ` [PATCH 3/2] rebase -i: recognize short commands without arguments Johannes Sixt
2018-10-26 1:26 ` Junio C Hamano
2018-10-26 8:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1810121732240.561@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=phillip.wood@talktalk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).