From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: range-diff, was Re: What's cooking in git.git (Jul 2018, #03; Wed, 25)
Date: Wed, 1 Aug 2018 18:01:46 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1808011800570.71@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqwotcivco.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Mon, 30 Jul 2018, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > FWIW I picked up your Asciidoc-underline fix, and I also fixed a typo in a
> > commit message (you may want to pick that up, too, unless you want me to
> > send a full new iteration, I don't care either way):
>
> Meaning that if you send a full new iteration it would match what we
> have on 'pu' plus the one-liner below? I think we can do without
> such a resend, because everybody has seen all there is to see if
> that is the case.
>
> > -- snipsnap --
> > 11: bf0a5879361 ! 11: 0c1f5db5d01 range-diff: add tests
> > @@ -3,7 +3,7 @@
> > range-diff: add tests
> >
> > These are essentially lifted from https://github.com/trast/tbdiff, with
> > - light touch-ups to account for the command now being names `git
> > + light touch-ups to account for the command now being named `git
> > range-diff`.
> >
> > Apart from renaming `tbdiff` to `range-diff`, only one test case needed
>
> I'll need to remember to rebuild es/format-patch-rangediff after
> amending bf0a587936 with this, but I think I should be able to push
> out the result in today's round.
>
> If any other issue arises, I do not mind taking an update, either,
> but I think at this point the topic is reaching the point of
> diminishing returns and should switch to incremental.
Thomas had a couple of good suggestions, still, and I am considering to
try to find time to simply disable the whitespace warnings altogether in
range-diff.
Ciao,
Dscho
next prev parent reply other threads:[~2018-08-01 16:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 22:13 What's cooking in git.git (Jul 2018, #03; Wed, 25) Junio C Hamano
2018-07-25 22:56 ` Stefan Beller
2018-07-25 23:43 ` Junio C Hamano
2018-07-26 4:14 ` Junio C Hamano
2018-07-26 16:56 ` Junio C Hamano
2018-07-25 23:47 ` Junio C Hamano
2018-07-25 23:48 ` Junio C Hamano
2018-07-26 4:15 ` Junio C Hamano
2018-07-26 6:07 ` Оля Тележная
2018-07-26 16:57 ` Junio C Hamano
2018-08-02 12:41 ` Christian Couder
2018-08-02 18:40 ` Junio C Hamano
2018-07-26 7:24 ` Jeff King
2018-07-26 16:57 ` Junio C Hamano
2018-07-26 20:46 ` Jeff King
2018-07-27 14:28 ` Ævar Arnfjörð Bjarmason
2018-07-27 17:28 ` Junio C Hamano
2018-07-30 13:16 ` range-diff, was " Johannes Schindelin
2018-07-30 15:41 ` Junio C Hamano
2018-08-01 16:01 ` Johannes Schindelin [this message]
2018-08-01 19:11 ` Junio C Hamano
2018-08-01 20:44 ` ds/reachable (was Re: What's cooking in git.git (Jul 2018, #03; Wed, 25)) Derrick Stolee
2018-08-01 21:55 ` Junio C Hamano
2018-08-01 20:53 ` ds/multi-pack-index " Derrick Stolee
2018-08-01 22:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1808011800570.71@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).