From: Christian Couder <christian.couder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Оля Тележная" <olyatelezhnaya@gmail.com>, git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Jul 2018, #03; Wed, 25)
Date: Thu, 2 Aug 2018 14:41:40 +0200 [thread overview]
Message-ID: <CAP8UFD0yWYvrbgtKjUs8oVks36Rp4qpfGAj3tambixSeC+-_1w@mail.gmail.com> (raw)
In-Reply-To: <xmqqpnzaq6jf.fsf@gitster-ct.c.googlers.com>
On Thu, Jul 26, 2018 at 6:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Оля Тележная <olyatelezhnaya@gmail.com> writes:
>
>> 2018-07-26 1:13 GMT+03:00 Junio C Hamano <gitster@pobox.com>:
>>>
>>> * ot/ref-filter-object-info (2018-07-17) 5 commits
>>> - ref-filter: use oid_object_info() to get object
>>> - ref-filter: merge get_obj and get_object
>>> - ref-filter: initialize eaten variable
>>> - ref-filter: fill empty fields with empty values
>>> - ref-filter: add info_source to valid_atom
>>>
>>> A few atoms like %(objecttype) and %(objectsize) in the format
>>> specifier of "for-each-ref --format=<format>" can be filled without
>>> getting the full contents of the object, but just with the object
>>> header. These cases have been optimzied by calling
>>> oid_object_info() API.
>>>
>>> What's the doneness of this one?
>>
>> It is ready. Thanks.
>
> Thanks, the question was meant more to the reviewers and mentors
> than the original author, though ;-)
I just tested this patch series on git.git on my laptop with the following:
$ time git for-each-ref --format='%(objecttype)' >/dev/null
and the best I can get without it is:
real 0m0,038s
user 0m0,034s
sys 0m0,004s
while with it I can get:
real 0m0,017s
user 0m0,016s
sys 0m0,000s
The results are similar with --format='%(objectsize)'.
So I think it is a nice improvement.
Looking at the code of the patches again, I can't see any simple way
to improve on the way it is done.
Thanks,
Christian.
next prev parent reply other threads:[~2018-08-02 12:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 22:13 What's cooking in git.git (Jul 2018, #03; Wed, 25) Junio C Hamano
2018-07-25 22:56 ` Stefan Beller
2018-07-25 23:43 ` Junio C Hamano
2018-07-26 4:14 ` Junio C Hamano
2018-07-26 16:56 ` Junio C Hamano
2018-07-25 23:47 ` Junio C Hamano
2018-07-25 23:48 ` Junio C Hamano
2018-07-26 4:15 ` Junio C Hamano
2018-07-26 6:07 ` Оля Тележная
2018-07-26 16:57 ` Junio C Hamano
2018-08-02 12:41 ` Christian Couder [this message]
2018-08-02 18:40 ` Junio C Hamano
2018-07-26 7:24 ` Jeff King
2018-07-26 16:57 ` Junio C Hamano
2018-07-26 20:46 ` Jeff King
2018-07-27 14:28 ` Ævar Arnfjörð Bjarmason
2018-07-27 17:28 ` Junio C Hamano
2018-07-30 13:16 ` range-diff, was " Johannes Schindelin
2018-07-30 15:41 ` Junio C Hamano
2018-08-01 16:01 ` Johannes Schindelin
2018-08-01 19:11 ` Junio C Hamano
2018-08-01 20:44 ` ds/reachable (was Re: What's cooking in git.git (Jul 2018, #03; Wed, 25)) Derrick Stolee
2018-08-01 21:55 ` Junio C Hamano
2018-08-01 20:53 ` ds/multi-pack-index " Derrick Stolee
2018-08-01 22:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD0yWYvrbgtKjUs8oVks36Rp4qpfGAj3tambixSeC+-_1w@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=olyatelezhnaya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).