From: Jakub Narebski <jnareb@gmail.com>
To: Nazri Ramliy <ayiehere@gmail.com>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] Bugfix: grep: Do not colorize output when -O is set
Date: Sat, 03 Jul 2010 00:59:24 -0700 (PDT) [thread overview]
Message-ID: <m3wrtdm1y9.fsf@localhost.localdomain> (raw)
In-Reply-To: <AANLkTilI0NZiDk3I850x28pr5I0sYRiPLW7HAST9sduU@mail.gmail.com>
Nazri Ramliy <ayiehere@gmail.com> writes:
> Something like the following will do (I'm doing this in gmail so sorry
> for any tabs<->space conversion):
>
> test_expect_success 'copes with color.ui' '
> rm -f actual &&
> echo grep.h >expect &&
> git config color.ui always &&
> git config color.grep.filename yellow &&
> test_when_finished "git config --unset color.ui" &&
> test_when_finished "git config --unset color.grep.filename" &&
> git grep -O'\''printf "%s\n" >actual'\'' GREP_AND &&
> test_cmp expect actual
> '
Sidenote: test_when_finished, introduced by Jonathan Nieder in 3bf7886
(test-lib: Let tests specify commands to be run at end of test,
2010-05-02) is not documented in t/README. Also, shouldn't it be
named 'when_finished_test' rather than 'test_when_finished'?
Currently 'test_when_finished' / 'when_finished_test' is used only in
t0000-basic and t7509-commit.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-07-03 7:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 10:02 [PATCH] Bugfix: grep: Do not colorize output when -O is set Nazri Ramliy
2010-07-02 16:19 ` René Scharfe
2010-07-06 19:38 ` Jonathan Nieder
2010-07-06 20:19 ` René Scharfe
2010-07-02 19:21 ` Jonathan Nieder
2010-07-03 1:20 ` Nazri Ramliy
2010-07-03 2:55 ` [PATCH v2] grep -O: Do not pass color sequences as filenames to pager Jonathan Nieder
2010-07-03 7:59 ` Jakub Narebski [this message]
2010-07-06 20:04 ` [PATCH] t/README: document more test helpers Jonathan Nieder
2010-07-06 20:23 ` Ævar Arnfjörð Bjarmason
2010-07-07 4:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wrtdm1y9.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=avarab@gmail.com \
--cc=ayiehere@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).