From: Nazri Ramliy <ayiehere@gmail.com>
To: gitster@pobox.com, git@vger.kernel.org
Cc: johannes.schindelin@gmx.de, jrnieder@gmail.com,
Nazri Ramliy <ayiehere@gmail.com>
Subject: [PATCH] Bugfix: grep: Do not colorize output when -O is set
Date: Fri, 2 Jul 2010 18:02:21 +0800 [thread overview]
Message-ID: <1278064941-30689-1-git-send-email-ayiehere@gmail.com> (raw)
When color.ui is set to auto, "git grep -Ovi foo" breaks due to the
presence of color escape sequences.
Signed-off-by: Nazri Ramliy <ayiehere@gmail.com>
---
Breakage aside, 'git grep -Ovi' really rocks!
builtin/grep.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin/grep.c b/builtin/grep.c
index 232cd1c..597f76b 100644
--- a/builtin/grep.c
+++ b/builtin/grep.c
@@ -1001,6 +1001,7 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
if (show_in_pager == default_pager)
show_in_pager = git_pager(1);
if (show_in_pager) {
+ opt.color = 0;
opt.name_only = 1;
opt.null_following_name = 1;
opt.output_priv = &path_list;
--
1.7.1.245.g7c42e.dirty
next reply other threads:[~2010-07-02 10:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 10:02 Nazri Ramliy [this message]
2010-07-02 16:19 ` [PATCH] Bugfix: grep: Do not colorize output when -O is set René Scharfe
2010-07-06 19:38 ` Jonathan Nieder
2010-07-06 20:19 ` René Scharfe
2010-07-02 19:21 ` Jonathan Nieder
2010-07-03 1:20 ` Nazri Ramliy
2010-07-03 2:55 ` [PATCH v2] grep -O: Do not pass color sequences as filenames to pager Jonathan Nieder
2010-07-03 7:59 ` [PATCH] Bugfix: grep: Do not colorize output when -O is set Jakub Narebski
2010-07-06 20:04 ` [PATCH] t/README: document more test helpers Jonathan Nieder
2010-07-06 20:23 ` Ævar Arnfjörð Bjarmason
2010-07-07 4:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278064941-30689-1-git-send-email-ayiehere@gmail.com \
--to=ayiehere@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).