From: Jakub Narebski <jnareb@gmail.com>
To: Ondra Medek <xmedeko@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: gitweb showing slash r at the end of line
Date: Mon, 30 Jan 2012 01:23:05 -0800 (PST) [thread overview]
Message-ID: <m3obtlczmu.fsf@localhost.localdomain> (raw)
In-Reply-To: <1327910140526-7235866.post@n2.nabble.com>
Ondra Medek <xmedeko@gmail.com> writes:
> I have read "SubmittingPatches". I have made a path by "git format-patch -M"
> and I have though it's enough. The problem maybe was, that I had not
> included "Subject: " from the result of "git format-patch -M". Next time I
> will try to do it better.
The problem is that in place of proper commit message, describing
change for posteriority as described in SubmittingPatches, you have an
email describing why you created this commit:
OM> Hi,
OM> we have gitweb running on Linux box. Some files have Windows line ending
OM> (CRLF) end we do not use core.autcrlf translation. gitweb show the last \r
OM> in the end of each line, which is annoying. I have creates a simple patch to
OM> avoid this. It adds just one line. I am not sure if the regexp should
OM> contain 'g' switch in the end. Also, not sure if there shoul be some config
OM> option to switch on/off this?
OM>
OM> Cheers
OM> Ondra
Take a look how other commit messages are written in git.git, and
please remember to sign off your patches.
> I am a Git newbie, but my bare repos have "config" file and this file can
> contain the "core.autocrlf" setting. So the gitweb can read it. Or what
> about to have a special section [gitweb] in this config? For now, the gitweb
> config files are somewhat "scattered" = "descrition", "cloneurl",
> "project.list", ...
The [gitweb] section contains stuff that can be used instead of
individual files like 'description' ('gitweb.description' can be used
instead if that file is not present), and also to configure
overridable features on per-repository basis, like 'gitweb.snapshot'.
> Yeah, the autodetection of mixed mode line endings could be the best
> solution.
>
> However, from my point of view a global gitweb setting would be enough for
> now.
I think that if not using autodetection this should be made into
proper gitweb %feature, e.g. named 'eol' - this automatically gives
ability to override it on per-repository basis via repo config.
--
Jakub Narebski
next prev parent reply other threads:[~2012-01-30 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 14:19 gitweb showing slash r at the end of line Ondra Medek
2012-01-27 21:35 ` Jakub Narebski
2012-01-27 23:15 ` Junio C Hamano
2012-01-28 17:02 ` Jakub Narebski
2012-01-30 7:55 ` Ondra Medek
2012-01-30 9:23 ` Jakub Narebski [this message]
2012-01-30 16:09 ` Ondra Medek
2012-02-02 20:04 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3obtlczmu.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=xmedeko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).