From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Ondra Medek <xmedeko@gmail.com>, git@vger.kernel.org
Subject: Re: gitweb showing slash r at the end of line
Date: Fri, 27 Jan 2012 15:15:36 -0800 [thread overview]
Message-ID: <7vvcnwybxj.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <m3aa58eskw.fsf@localhost.localdomain> (Jakub Narebski's message of "Fri, 27 Jan 2012 13:35:45 -0800 (PST)")
Jakub Narebski <jnareb@gmail.com> writes:
> Ondra Medek <xmedeko@gmail.com> writes:
>
>> we have gitweb running on Linux box. Some files have Windows line ending
>> (CRLF) end we do not use core.autcrlf translation. gitweb show the last \r
>> in the end of each line, which is annoying.
>
> Well, this "\r" allows to recognize when file with Windows line ending
> (CRLF) made it into repository... which usually is discouraged. But
> if you allow this, I can understand that those "\r" at the end of
> every line can be annoying.
I think the right thing to do is:
* If the repository data is _supposed_ to have CRLF endings (e.g. check
with core.crlf or something), strip \r and do not show them.
* Otherwise, i.e. if the repository data is supposed _not_ to have CRLF
endings, do show these '\r'. Annoyance here is a *feature* to remind
the viewer that the contents needs _fixing_.
* No other switches.
next prev parent reply other threads:[~2012-01-27 23:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 14:19 gitweb showing slash r at the end of line Ondra Medek
2012-01-27 21:35 ` Jakub Narebski
2012-01-27 23:15 ` Junio C Hamano [this message]
2012-01-28 17:02 ` Jakub Narebski
2012-01-30 7:55 ` Ondra Medek
2012-01-30 9:23 ` Jakub Narebski
2012-01-30 16:09 ` Ondra Medek
2012-02-02 20:04 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvcnwybxj.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=xmedeko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).