From: Jakub Narebski <jnareb@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/6] Make test-lib.sh emit valid TAP format
Date: Fri, 07 May 2010 13:17:49 -0700 (PDT) [thread overview]
Message-ID: <m37hnffow2.fsf@localhost.localdomain> (raw)
In-Reply-To: <1273261025-31523-1-git-send-email-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> TAP, the the Test Anything Protocol, is a simple text-based interface
> between testing modules in a test harness. test-lib.sh's output was
> already very close to being valid TAP. This change brings it all the
> way there.
>
> The advantage of using TAP is that any program that reads the format
> (a "test harness") can run the tests. The most popular of these is the
> prove(1) utility that comes with Perl. It can run tests in parallel,
> display colored output, format the output to console, file, HTML etc.,
> and much more.
>
> On my quad Xeon server running the test suite with `make test` takes
> 21 minutes. Running it with `prove -j 15 ./t[0-9]*.sh` takes just over
> 5 minutes.
>
> With parallel tests the whole test suite doesn't have to stall because
> tests like t3404-rebase-interactive.sh take a long time.
I would have thought that it would be better for git test suite to
enable TAP output with --tap switch. On the other hand changing
output to TAP, replacing old format, would be less code to maintain.
I am not sure if testing with 'prove' and TAP output is compatibile
with all current git test suite options, i.e. --debug, --tee,
--verbose and --immediate, and with GIT_SKIP_TESTS environmental
variable. Also valuable way of checking where the error occurs in the
test, namely 'sh -x ./tXXXX-test.sh' would not work, I think, with
'prove'.
Note also that having Perl (and 'prove') installed is not requirement
for git runnig, and I think it should not be requirement for git
development.
P.S. I think that such series would be better with the cover letter.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-05-07 20:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 19:37 [PATCH 1/6] Make test-lib.sh emit valid TAP format Ævar Arnfjörð Bjarmason
2010-05-07 19:37 ` [PATCH 2/6] Move t6000lib.sh to lib-* Ævar Arnfjörð Bjarmason
2010-05-07 20:21 ` Jakub Narebski
2010-05-07 19:37 ` [PATCH 3/6] Skip tests in a way that makes sense under TAP Ævar Arnfjörð Bjarmason
2010-05-07 19:37 ` [PATCH 4/6] Turn setup code in t2007-checkout-symlink.sh into a test Ævar Arnfjörð Bjarmason
2010-05-07 20:23 ` Jakub Narebski
2010-05-07 19:37 ` [PATCH 5/6] We use TAP so the Perl test can run without scaffolding Ævar Arnfjörð Bjarmason
2010-05-07 19:37 ` [PATCH 6/6] Add test_harness make target for testing with prove(1) Ævar Arnfjörð Bjarmason
2010-05-07 20:20 ` Jakub Narebski
2010-05-08 3:58 ` Junio C Hamano
2010-05-09 11:04 ` Tor Arntsen
2010-05-07 19:50 ` [PATCH 1/6] Make test-lib.sh emit valid TAP format Sverre Rabbelier
2010-05-07 20:25 ` Ævar Arnfjörð Bjarmason
2010-05-07 20:59 ` [PATCH 1/6 v2] " Ævar Arnfjörð Bjarmason
2010-05-15 19:37 ` Ævar Arnfjörð Bjarmason
2010-05-07 20:17 ` Jakub Narebski [this message]
2010-05-07 20:49 ` [PATCH 1/6] " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37hnffow2.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).