From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 6/6] Add test_harness make target for testing with prove(1)
Date: Fri, 07 May 2010 20:58:06 -0700 [thread overview]
Message-ID: <7vwrvfcaep.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <m339y3forb.fsf@localhost.localdomain> (Jakub Narebski's message of "Fri\, 07 May 2010 13\:20\:28 -0700 \(PDT\)")
Jakub Narebski <jnareb@gmail.com> writes:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> The --jobs option I'm supplying to prove(1) is not supported in all
>> prove versions, some older ones (before Perl 5.10.1) don't have
>> it. Anyone that's hacking Git probably has 5.10.1, and you can always
>> use the old `make test` for non-parallel tests.
>
> I am hacking Git, and I don't have perl >= 5.10.1. On the other hand
> I can alway run "make test" or individual tests instead of
> "make test_harness".
>
> A better solution would be to check Perl version, or even better of
> "prove" supports '--jobs' option, and selectively enable parallel
> running of test harness in Makefile.
Besides, "make -j15 test" from the toplevel already runs the tests in
parallel. I don't see much point in this change.
next prev parent reply other threads:[~2010-05-08 3:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 19:37 [PATCH 1/6] Make test-lib.sh emit valid TAP format Ævar Arnfjörð Bjarmason
2010-05-07 19:37 ` [PATCH 2/6] Move t6000lib.sh to lib-* Ævar Arnfjörð Bjarmason
2010-05-07 20:21 ` Jakub Narebski
2010-05-07 19:37 ` [PATCH 3/6] Skip tests in a way that makes sense under TAP Ævar Arnfjörð Bjarmason
2010-05-07 19:37 ` [PATCH 4/6] Turn setup code in t2007-checkout-symlink.sh into a test Ævar Arnfjörð Bjarmason
2010-05-07 20:23 ` Jakub Narebski
2010-05-07 19:37 ` [PATCH 5/6] We use TAP so the Perl test can run without scaffolding Ævar Arnfjörð Bjarmason
2010-05-07 19:37 ` [PATCH 6/6] Add test_harness make target for testing with prove(1) Ævar Arnfjörð Bjarmason
2010-05-07 20:20 ` Jakub Narebski
2010-05-08 3:58 ` Junio C Hamano [this message]
2010-05-09 11:04 ` Tor Arntsen
2010-05-07 19:50 ` [PATCH 1/6] Make test-lib.sh emit valid TAP format Sverre Rabbelier
2010-05-07 20:25 ` Ævar Arnfjörð Bjarmason
2010-05-07 20:59 ` [PATCH 1/6 v2] " Ævar Arnfjörð Bjarmason
2010-05-15 19:37 ` Ævar Arnfjörð Bjarmason
2010-05-07 20:17 ` [PATCH 1/6] " Jakub Narebski
2010-05-07 20:49 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwrvfcaep.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).