git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Krzysztof Halasa <khc@pm.waw.pl>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] git-apply: add tests for stripping of leading and trailing whitespace
Date: Tue, 18 Sep 2007 01:44:46 +0200	[thread overview]
Message-ID: <m31wcwsvpt.fsf@maximus.localdomain> (raw)
In-Reply-To: <20070917150213.GB4957@fieldses.org> (J. Bruce Fields's message of "Mon, 17 Sep 2007 11:02:13 -0400")

"J. Bruce Fields" <bfields@fieldses.org> writes:

>> It may be valid, some projects use tabs for indentation and spaces
>> for alignment, e.g.:
>
> Yeah, I know.  I was hoping that the stripspace behavior was already
> specific enough to the linux-kernel style that we could just assume that 
> it was only used by developers on projects with the same style.

Actually I would consider linux kernel an example of such project
with spaces for alignment. Except that current tools are not to
the task. Someday...

Obviously other cases are valid, especially 'spaces before tabs'
which IMHO includes '8 or more non-consecutive initial spaces'.
And all trailing whitespace of course.
-- 
Krzysztof Halasa

  reply	other threads:[~2007-09-17 23:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-16 22:48 whitespace-stripping J. Bruce Fields
2007-09-16 22:49 ` [PATCH 1/3] git-apply: fix whitespace stripping J. Bruce Fields
2007-09-16 22:49   ` [PATCH 2/3] git-apply: complain about >=8 consecutive spaces in initial indent J. Bruce Fields
2007-09-16 22:49     ` [PATCH 3/3] git-apply: add tests for stripping of leading and trailing whitespace J. Bruce Fields
2007-09-17 14:16       ` Krzysztof Halasa
2007-09-17 15:02         ` J. Bruce Fields
2007-09-17 23:44           ` Krzysztof Halasa [this message]
2007-09-18  0:53             ` J. Bruce Fields
2007-09-16 23:24     ` [PATCH 2/3] git-apply: complain about >=8 consecutive spaces in initial indent Martin Langhoff
2007-09-17  2:45       ` J. Bruce Fields
2007-09-17  0:24     ` Junio C Hamano
2007-09-17  2:44       ` J. Bruce Fields
2007-10-03  1:00     ` [PATCH] git-diff: " Junio C Hamano
2007-09-18  8:55   ` [PATCH 1/3] git-apply: fix whitespace stripping David Kastrup
2007-09-18 13:12     ` J. Bruce Fields
2007-09-18 14:18       ` David Kastrup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31wcwsvpt.fsf@maximus.localdomain \
    --to=khc@pm.waw.pl \
    --cc=bfields@fieldses.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).