From: David Kastrup <dak@gnu.org>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/3] git-apply: fix whitespace stripping
Date: Tue, 18 Sep 2007 16:18:14 +0200 [thread overview]
Message-ID: <867imo3vmh.fsf@lola.quinscape.zz> (raw)
In-Reply-To: 20070918131237.GA12120@fieldses.org
"J. Bruce Fields" <bfields@fieldses.org> writes:
> On Tue, Sep 18, 2007 at 10:55:25AM +0200, David Kastrup wrote:
>> As far as I can see, this does not really work since it does not
>> maintain an idea of a current column.
>>
>> If you have
>>
>> abcd<four spaces><tab><four spaces><tab>
>>
>> then indeed the resulting conversion needs to be <tab><tab><tab>
>> whereas with
>>
>> abc<four spaces><tab><four spaces><tab>
>>
>> the resulting conversion needs to be just <tab><tab>
>
> Note that this code *only* handles whitespace in the initial indent;
> processing stops as soon as it hits anything other than a tab or an
> indent.
>
> Given that, I believe the proposed patch is correct. Am I missing
> something else?
Don't think so. Sorry for the noise.
--
David Kastrup
prev parent reply other threads:[~2007-09-18 14:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 22:48 whitespace-stripping J. Bruce Fields
2007-09-16 22:49 ` [PATCH 1/3] git-apply: fix whitespace stripping J. Bruce Fields
2007-09-16 22:49 ` [PATCH 2/3] git-apply: complain about >=8 consecutive spaces in initial indent J. Bruce Fields
2007-09-16 22:49 ` [PATCH 3/3] git-apply: add tests for stripping of leading and trailing whitespace J. Bruce Fields
2007-09-17 14:16 ` Krzysztof Halasa
2007-09-17 15:02 ` J. Bruce Fields
2007-09-17 23:44 ` Krzysztof Halasa
2007-09-18 0:53 ` J. Bruce Fields
2007-09-16 23:24 ` [PATCH 2/3] git-apply: complain about >=8 consecutive spaces in initial indent Martin Langhoff
2007-09-17 2:45 ` J. Bruce Fields
2007-09-17 0:24 ` Junio C Hamano
2007-09-17 2:44 ` J. Bruce Fields
2007-10-03 1:00 ` [PATCH] git-diff: " Junio C Hamano
2007-09-18 8:55 ` [PATCH 1/3] git-apply: fix whitespace stripping David Kastrup
2007-09-18 13:12 ` J. Bruce Fields
2007-09-18 14:18 ` David Kastrup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867imo3vmh.fsf@lola.quinscape.zz \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).